I built the first install with the old file, then changed the file and built the second install. Individually each install works fine, and the second install has the correct file with it. So I think the MSIs have been built properly. I also have changed the version number - in the first one it is 1.0.0.0 and in the second it is 1.0.1.0 (I changed the third number since it seems the last digit is ignored).
I do see the pdf file name in the wixmst file. The files sizes are different but I am not sure if that qualifies for the binary diff between the 2 files (I would think it should). I will try changing the version number to be a minor upgrade, but doesn't that defeat the purpose of a patch? I have looked at both MSI files in Orca and I see the file sizes for the pdf file are different. As I have questioned before, is the file size change something that torch should see as a difference when building the wixmst file? -----Original Message----- From: Peter Shirtcliffe [mailto:pshirtcli...@sdl.com] Sent: Wednesday, August 01, 2012 8:56 AM To: General discussion for Windows Installer XML toolset. Subject: Re: [WiX-users] Assistance with creating a patch How you build is up to you. As long as the MSIs that come out of the build contain the correct files, then it's a valid method. From your description, it's not clear if you're building the MSI before or after you change the file in the first ads_install directory, which might be where you're going wrong. You should validate that your MSIs have built properly and are correct by performing a minor upgrade using the 2 MSIs. If that fails, examine each one with Orca to check that the file table entries are what you expect. Look in the wixmst: you should be able to find your PDF file's name. If it's in the wixmst, then pyro will bring it into the patch if a binary diff of the 2 versions shows that they differ. You've only posted the wix source for the release version. Did you remember to change the product version (and retain the product code) in the second installer's source code ? -----Original Message----- From: Jeanne Dixon [mailto:jdi...@cots.com] Sent: 01 August 2012 12:11 To: General discussion for Windows Installer XML toolset. Subject: Re: [WiX-users] Assistance with creating a patch It is good to know I don't have to update all files with a version number. I redid my pyro statement to use "ADSPatch" but I still get the same error. I am obviously missing something. What I have tried to do is use the same directory for both builds. I have a directory (I'll refer to it as the main directory) that contains subordinate directories that contain all my source and support files . I put the wix build and all files in a directory called ads_install under the main directory for the first build, then changed the one file, then created a copy of the install directory and called it ads_patch1. This way all the files are only in one main directory and the only differences are the new install directory for the patch and the one file that has changed. Do I need to create an entire second main directory just for a patch? I would think the msi should contain the changed file, and since the file size is different torch should be able to pick up the difference between them. What is the correct way to do this? -----Original Message----- From: Peter Shirtcliffe [mailto:pshirtcli...@sdl.com] Sent: Wednesday, August 01, 2012 5:28 AM To: General discussion for Windows Installer XML toolset. Subject: Re: [WiX-users] Assistance with creating a patch I found your original message and it looks like you're updating a PDF. Those don't have Windows version resources, so ignore me there. You can remove those edits you made with Orca. The patchbaseline in the patch.wxs has the Id "ADSPatch". This Id must match the -t argument passed to pyro, which you've given the value "RTM". Just change one of them so they have the same value. -----Original Message----- From: Jeanne Dixon [mailto:jdi...@cots.com] Sent: 31 July 2012 20:13 To: General discussion for Windows Installer XML toolset. Subject: Re: [WiX-users] Assistance with creating a patch I used Orca to put version numbers on the file in both msi projects and re-ran torch and pyro, but it still gives me the error about no valid transforms. -----Original Message----- From: Peter Shirtcliffe [mailto:pshirtcli...@sdl.com] Sent: Tuesday, July 31, 2012 12:41 PM To: General discussion for Windows Installer XML toolset. Subject: Re: [WiX-users] Assistance with creating a patch Does your changed file have a version resource and, if so, did the version increase in the updated file ? -----Original Message----- From: Jeanne Dixon [mailto:jdi...@cots.com] Sent: 31 July 2012 17:28 To: General discussion for Windows Installer XML toolset. Subject: Re: [WiX-users] Assistance with creating a patch I just read an article that made me realize I have an error in my pyro command. It should read: Pyro ADSPatch1.wixmsp -out ADSPatch1.msp -t ADSPatch ADSPatch1.wixmst This now gives me a warning: PYRO1079: the cab file does not contain any files. I do have the changed file in a ComponentRef in the patch file, so I am not sure why I got this. This is then followed by the error: PYRO0227: The transforms being built did not contain any references so it could not be created. So I am still at a stopping point where my transforms are not being built. I have looked at both msi files in Orca and the file sizes for the changed file are different. I though that was enough for it to see the differences but it does not seem that way. How do I get the processes to see the changed file? -----Original Message----- From: Jeanne Dixon [mailto:jdi...@cots.com] Sent: Tuesday, July 31, 2012 11:24 AM To: General discussion for Windows Installer XML toolset. Subject: Re: [WiX-users] Assistance with creating a patch Sorry for not getting back to this sooner. I am using visual studio to create the msi and wixpdb files for both versions. I then use light to create the patch .wixmsp file Light ADSPatch1.wixobj -out ADSPatch1.wixmsp Then I try to use pyro to build the patch Pyro ADSPatch1.wixmsp -out ADSPatch1.msp -t RTM ADSPatch1.wixmst The pyro command returns the error: PYRO0252: No valid transforms were provided. The torch error for some reason is now not coming up. I still don't understand why pyro does not see any valid transforms. -----Original Message----- From: Peter Marcu [mailto:peter.ma...@microsoft.com] Sent: Monday, July 16, 2012 1:01 AM To: General discussion for Windows Installer XML toolset. Subject: Re: [WiX-users] Assistance with creating a patch It would be helpful to know the commands you are using to generate your initial packages as well as your patches. It sounds like you may be having a problem because the base path where its looking for the contents of your admin image doesn't exist. Does this location exist? 'C:\ADS_AutoUpdate\ADS_Install\bin\debug\ADSD\ADS.exe' -----Original Message----- From: Jeanne Dixon [mailto:jdi...@cots.com] Sent: Friday, July 13, 2012 10:08 AM To: wix-users@lists.sourceforge.net Subject: [WiX-users] FW: Assistance with creating a patch I added back into the patch the componentref for the changed file and that got rid of the funny file error. However, I still have the No valid transforms error. It also seems mu file attachments did not go through, so I will paste them here. Product.wxs: <?xml version="1.0" encoding="UTF-8"?> <Wix xmlns="http://schemas.microsoft.com/wix/2006/wi";> <Product Id="1F4BF3CB-0221-40A0-AB57-8989358F9C46" Name="ADS" Language="1033" Version="1.0.0.0" Manufacturer="me" UpgradeCode="2076411E-2B76-4A7A-9B07-930B2ABD16D1"> <!--Package InstallerVersion="200" Compressed="yes" /--> <Package InstallerVersion="200" Compressed="yes" InstallScope="perMachine" AdminImage="yes"/> <Media Id="1" Cabinet="ads7.cab" EmbedCab="yes" /> <Property Id="DBUpdate">1</Property> <!--Property Id="ALLUSERS">"1"</Property--> <Property Id ="WIXUI_INSTALLDIR" Value="INSTALLLOCATION"></Property> <WixVariable Id="WixUIBannerBmp" Value=".\bitmap\banner.bmp"/> <WixVariable Id="WixUIDialogBmp" Value=".\bitmap\background.bmp"/> <!-- this is for the shortcut --> <Icon Id="globe.ico" SourceFile="..\ADS7\image\globe.ico"/> <!-- make the path release once this is working --> <Binary Id ="SupportDLL" SourceFile="..\ADS_Support\bin\Debug\ADS_Support.CA.dll" /> <CustomAction Id="UpdateDB" BinaryKey="SupportDLL" DllEntry="DBUpdate" Return="check"></CustomAction> <UI> <ProgressText Action="UpdateDB">Verifying Database Settings</ProgressText> </UI> <UIRef Id ="WixUI_InstallDir_NoLic"/> <InstallExecuteSequence> <!-- if the flag is set do the database update stuff --> <!--Custom Action="UpdateDB" After="InstallFinalize">(DBUpdate=1) AND ((Installed) OR (Repaired)) AND NOT (REMOVE="ALL")</Custom--> <Custom Action="UpdateDB" After="InstallFinalize">(DBUpdate=1) AND NOT (REMOVE="ALL") AND NOT (PATCH)</Custom> </InstallExecuteSequence> <FeatureRef Id="ProductFeature"/> </Product> <Fragment> <Directory Id="TARGETDIR" Name="SourceDir"> <Directory Id="ProgramFilesFolder"> <Directory Id="INSTALLLOCATION" Name="ADSD"> <Component Id="ADS7" Guid="8DF796C4-F3C3-4352-A796-5D3174FA0D7F"> <File Id ="ADS7.exe" Source="..\ADS7\bin\$(var.ADS_Install.Configuration)\ADS7.exe"/> <Shortcut Id="ADSDesktopShortcut" Directory="DesktopFolder" Name="ADS" Advertise="yes" Icon="globe.ico"/> <Shortcut Id="ADSShortcut" Directory="ShortcutsDir" Name="ADS" Advertise="yes" Description="ADS" Icon="globe.ico"/> </Component> <!-- the following are the app subdirectories and files --> <Directory Id ="Reports" Name="report"/> <Directory Id="DBData" Name="data"/> <Directory Id="HelpDir" Name="help"/> </Directory> <!-- install --> </Directory> <!-- program files --> <Directory Id="CommonAppDataFolder"> <Directory Id="ADS7Data" Name="ADSData"> <Directory Id="AppCheck" Name="check"/> <Directory Id="AppData" Name="data"> <Directory Id="AppDataStore" Name="store"/> <Directory Id="AppDataArchive" Name="archive"/> </Directory> <!-- data dir --> <Directory Id="AppErrorLog" Name="errorlog"/> <Directory Id="AppPdf" Name="pdf"/> </Directory> <!-- ads7 --> </Directory> <!-- common data --> <!-- this sets up the shortcuts --> <Directory Id="ProgramMenuFolder"> <Directory Id="ShortcutsDir" Name="ADS"/> <Component Id="ShortcutsDir" Guid="C2A4E076-5E4b-441C-9C8C-603BAFFF2301"> <RemoveFolder Id="RemoveShortcutsDir" Directory="ShortcutsDir" On="uninstall"/> <RegistryValue Root="HKMU" Key="Software\me\ADS" Type="integer" Value="1" KeyPath="yes" /> </Component> </Directory> <!-- program menu folder --> <Directory Id="DesktopFolder" Name="Desktop"/> </Directory> <!-- targetdir --> </Fragment> <Fragment> <Feature Id="ProductFeature" Title="ADS" Level="1"> <ComponentRef Id="ADS" /> <ComponentGroupRef Id="ReportsGroup"/> <ComponentGroupRef Id="DBData"/> <ComponentGroupRef Id="UserDirGroup"/> <ComponentGroupRef Id="DLLGroup"/> <ComponentRef Id="NoChart"/> <ComponentRef Id ="HelpFile"/> <ComponentRef Id="ShortcutsDir"/> </Feature> </Fragment> <!--putting the nochart pdf here since it is a directory of its own --> <Fragment> <Component Id="NoChart" Directory="AppPdf" Guid="{E5CF0EB0-7D45-42FA-B14A-DDB17EF66B0B}"> <File Id="nochart" KeyPath="yes" Source="$(var.ADS_Install.Reports)\nochart.pdf" /> </Component> </Fragment> <Fragment> <!-- put help here since it is just one file --> <Component Id="HelpFile" Directory="HelpDir" Guid="{00F3BF4D-C16C-4069-BFB1-F5D997F9C7F3}"> <File Id="helpfile" KeyPath="yes" Source="$(var.ADS_Install.Help)\ADSHelpE.chm" /> </Component> </Fragment> </Wix> Patch.wxs: <?xml version="1.0" encoding="UTF-8"?> <Wix xmlns="http://schemas.microsoft.com/wix/2006/wi";> <Patch AllowRemoval="yes" Classification="Update" Comments="Patch test for ADS" Description="Patch test for ADS" DisplayName="ADS7 Update" Manufacturer="COmputing TechnologieS, Inc" TargetProductName="Automated Data Systems 7"> <Media Id="1000" Cabinet="ads7patch1.cab"> <PatchBaseline Id="ADSPatch"/> </Media> <PatchFamilyRef Id="ADS7Patch1"/> </Patch> <Fragment> <PatchFamily Id="ADS7Patch1" Version="1.0.1.0" Supersede="yes"> <ComponentRef Id="NoChart"/> </PatchFamily> </Fragment> </Wix> ________________________________________ From: Jeanne Dixon [jdi...@cots.com] Sent: Friday, July 13, 2012 10:47 AM To: wix-users@lists.sourceforge.net Subject: [WiX-users] Assistance with creating a patch I am new to using WiX and have built my 2 installation packages successfully. The only difference between the first and second is an updated pdf file. I have tried to build the patch using torch with the .wixpdb files and I get a pryo error that says there are no valid transforms. If I try to use torch with the .msi files I get a strange error that says it can't find one of the files - the path it displays is a mix of the installation directory and the destination folder from the installation. I have put AdminImage="yes" into both installation packages to made them admin so I can use the msi files in torch. This is my understanding of what I needed to do following the web pages I have read (which are many). I have tried using the admin version because I also read that if you use the wixpdb files it does read the msi to find the file change and my updates are all currently within my working directory that I build the installation from, so the only file there is the latest one (so it will not be able to find the previous one). The msi files work fine for installation, but I don't understand why I am getting the error below when I use them in torch. torch.exe : error TRCH0258 : The file 'C:\ADS_AutoUpdate\ADS_Install\bin\debug\ADSD\ADS.exe' cannot be found. The part up to ADSD is where I am building my install (the source code is contained in a different directory) and the ADSD part is where I am telling the install to copy the exe file to after I specify the TARGETDIR directory in my wxs file. I have attached the product.wxs file and the patch wxs file. The file that I am trying to get built in as the patch is the "NoChart" file contained within the product.wxs file. I would prefer not to have multiple copies of the source code within each install directory, as that can get quite large. What am I doing wrong with this install and/or patch? Thanks in advance for the help! ----------------------------------------------------------------------------- - Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users ----------------------------------------------------------------------------- - Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users ----------------------------------------------------------------------------- - Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users ----------------------------------------------------------------------------- - Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users SDL PLC confidential, all rights reserved. If you are not the intended recipient of this mail SDL requests and requires that you delete it without acting upon or copying any of its contents, and we further request that you advise us. SDL PLC is a public limited company registered in England and Wales. Registered number: 02675207. Registered address: Globe House, Clivemont Road, Maidenhead, Berkshire SL6 7DY, UK. ----------------------------------------------------------------------------- - Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users ----------------------------------------------------------------------------- - Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users ----------------------------------------------------------------------------- - Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users ----------------------------------------------------------------------------- - Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users
