On Tue, 9 Dec 2008 22:32:33 -0800 "John H. Robinson, IV" <[EMAIL PROTECTED]> wrote:
> Gilbert wrote: > > Hello all, > > > > I'm attaching a tarball of 13 patches for evaluation & testing. These > > all apply to the latest devel sources from today. Most of the first > > patches are taken and updated from the ALT/Sisyphus linux srpm which > > was/is maintained by Alexy Voinov. One is a new patch which I > > created. The last ones are some patches that I found recently from a > > new BSD ports maintainer. > > > > Each patch is pretty well commented at the top and they are numbered > > for easier identification. At least one of them(01-WINGs-sowings.diff) > > will only apply cleanly after first running autogen.sh as it alters > > Makefile.am files which are not present in the raw repo sources. > > > > 00-WindowMaker-avoid_null_font.diff > > 01-WINGs-sowings.diff (This is needed for compiling/running wdm display > > manager) > This patch will have to be done differently - as it has to be > reproduceable if autogen.sh is run again. > Turns out I was mistaken about needing to ru autogens.sh first. I have been using and re-diffing this patch for 3-4 years, but lately I had a problem with it -utrns out that I had applied it after a failed untarring(out of space on device). Anyway, it works fine as is -all the mods are done to Makefile.am so it's sane. > > 02-WindowMaker-x86_64-mmx-fixes.diff > > 03-WindowMaker-maximize-borderless-fix-missing-pixels.diff > > 04-WindowMaker-xinerama-switchpanel-corruption-fix.diff > > 05-WindowMaker-textfield-adialog.diff (New feature) > > ( For some odd reason I cannot get the last fragment of this > > patch to work. It patches the file plmenu. It should be applied > > manually) I was having this problem the same days as above -now today I had no problem applying the patch normally > That last hunk by all means should apply. Is there a reason why the > order of XTerm and Run were changed? > Why was only plmenu changed, instead of including the translated > plmenus? > I had redone the patch a couple of times trying to fix the problem above and the move of RUN/XTerm creeped in there by mistake. I figure that patching the menus is kind of a convenience anyway. But, I have redone the patch to include most of the other menus as well as the English. I say most, because not all of the menus have an entry for Run at all. I have guessed on a couple which had an entry that seemed to be the right one. But there are inconsistencies in the menus -a couple apparently used EXEC when it should be SHEXEC for the Run box. And about half of the menus don't have any such entry at all -they all follow a similar form and syntax so they are probably hold-overs from a much earlier version. The new patch is attached. there may still be one issue, though. Look at line 233 of the patch, where the default name of the command-history file is set: + filename = wstrappend(filename, "/.AppInfo/WindowMaker/History"); I've had variable results with this when starting from a fresh default ~GNUstep directory. Once or twice, the histors function would not work, beacuse the directory ~GNUstep/.AppInfo/WindowMaker was not being created. Once I manually created it, there were no problems with the file ~GNUstep/.AppInfo/WindowMaker/History being created, as soon as I had change the menu entry and run any command from the Run box. The directory ~GNUstep/.AppInfo does get created without fail. Perhaps it would be better to change the path to simply: ~GNUstep/.AppInfo/History Or maybe even better: + filename = wstrappend(filename, "/.AppInfo/RunHistory"); because a filename can be passed in the menu entry to maintain separate history files for other commands which use the '%a' normally. Another line of thought that pertains to this: I have thought that it might be good to do away with all the GNUstep references and defaults, and use a more modern and freedesktop.org-conforming path for the personal config files -something like ~/.config/wmaker would seem to be more appropriate and less confusing for most users who are not 'GNUsteppers'. That project seems to be pretty obscure anyway, if not abandoned. I would ceratinly bet that there are more people using wmaker withotu GNUstep than with... Anywy, I have a patch here from somewhere, which changed the default config paths from ~/GNUstep to ~/.GNUstep. Obviouls it would be trivial to change this to whatever -of course we'd want to change the docs as well. Since you are (apparently) the Debian maintainer for wmaker, perhaps you could recruit some users who would update the menus to a current standard format and entries?? It would be really nice if we could get some work done on updating the documentation -I can help a little, but I have a collaborator who also uses wmaker who might be coerced into doing some serious work on the FAQ or other docs. > > 06-WindowMaker-singleclick.diff (New Feature) > This seems to be a popular feature. > > > 07-WindowMaker-confirm_kill_show_app_name.diff > Looks like a good idea - will have to test this in practice. > > > 08-WINGs_array_c.diff > > 09-WINGs_string_c.diff > > 10-WindowMaker-wtokensplit_no_null_argv.diff > > 11-WINGs_findfile_c.diff > > 12-WindowMaker-disable_unused_StartLogShell.diff > Deleting the function will be the better course of action. > I found this patch -I guess the author wanted to do the least intrusive thing possible. I have redone it to completely remove the functrion and attached it to this email. However, it might bear a little investigation -I don't think such a long function was written for nothing. Probably this was either left over from long ago, or was part of something that was just about to be implemented. > > If anyone has a chance to have a look at these, please do. Getting > > them in mainline will greatly reduce the number of patches i use with > > wmaker and there is very little code added by these patches. > > Most of these will go in with no problems. I still need to test them > all, but initial examination shows that most of these are good to go. > > Thank you very much, > > -- > John H. Robinson, IV [EMAIL PROTECTED] I have a handfull of other small patches which are less useful or more dubious, but I will wait about submitting them for review until after a new stable release. As we all seem to be working rather well as a team and mostly have the same sort of goals for keeping wmaker light and stable, I hope that we can settle in to work on getting the docs and web presence up to speed -the docs are what 10 years behind by now? And, while I don not wish to see wmaker become bloated with lots of extra stuff, I still feel that we could increase the 'uptake' by co-ordinating some of the accessories that go with it. I personally have quite a collection of stuff, particularly including wdm, the WSoundSever and wmakerconf as well as about 100 of the better DockApps and a lot of the them materials that were ever available -kind of a wmaker 'Heaven'. I don't have everything uploaded, but most of it is here: http://distro.ibiblio.org/pub/linux/distributions/amigolinux/download/DeskTop/WinMgrs/WindowMaker/ and here: http://distro.ibiblio.org/pub/linux/distributions/amigolinux/download/DockApps/ Thanks, Gilbert Ashley
remove_unused_StartLogShell.diff
Description: Binary data
05A-WindowMaker-textfield-adialog.diff
Description: Binary data
