On Fri, 26 Mar 2010 at 20:35:02 +0100, Tamas TEVESZ wrote:
>
> carlos, can you do it so that when patches do not clash (too much),
> you apply them to both next and cairo? that would probably help
> keeping cairo in line with developments that are not cairo-related.
Right, I will try to rebase #cairo to keep it updated with #next.
I haven't tried it yet, though.
Regarding the patch, I have a comment and a question.
> +
> +#define RETRY( x ) do { \
> + x; \
> + } while (errno == EINTR);
>
[...]
>
> - if ((src = open(srcFile, O_RDONLY | O_BINARY)) == 0) {
> + RETRY( src = fopen(srcFile, "rb") )
> + if (src == NULL) {
> wsyserror(_("Could not open %s"), srcFile);
> return -1;
> }
Using this RETRY() macro is a bit ugly. I didn't like from the look
of it.
So let me ask a question. What bad thing would happen if you don't
use this RETRY trick and do simply a
src = fopen(srcFile, "rb");
if (!src) {
wsyserror(_("Could not open %s"), srcFile);
return -1;
}
The old code didn't retry, why do you need it now?
--
To unsubscribe, send mail to [email protected].
