On Mon, 5 Apr 2010, Brad Jorsch wrote:
hi,
one thing that caught my eye:
> --- a/WPrefs.app/Paths.c
> +++ b/WPrefs.app/Paths.c
> @@ -154,6 +154,7 @@ static void browseForFile(WMWidget * w, void *data)
> lPtr = panel->icoL;
> else if (w == panel->pixaB)
> lPtr = panel->pixL;
> + else return;
>
> i = WMGetListSelectedItemRow(lPtr);
> if (i >= 0)
this turns Paths.c into:
149 if (len > 0) {
150 WMList *lPtr;
151 int i;
152
153 if (w == panel->icoaB)
154 lPtr = panel->icoL;
155 else if (w == panel->pixaB)
156 lPtr = panel->pixL;
157 else return;
158
159 i = WMGetListSelectedItemRow(lPtr);
160 if (i >= 0)
161 i++;
162 addPathToList(lPtr, i, str);
163 WMSetListBottomPosition(lPtr,
WMGetListNumberOfRows(lPtr));
164
165 wfree(str);
166 }
unless i should really be sleeping, the return is either bogus, or
158-165 should quite be killed, no?
the rest looks ok at a cursory skim, thanks!
--
[-]
mkdir /nonexistent
--
To unsubscribe, send mail to [email protected].
