On Mon, 5 Apr 2010 at 15:35:53 -0400, Brad Jorsch wrote: > Cleaned up a few errors, at least here now it will compile with > CFLAGS="-g -O2 -Wall -Wextra -Wno-sign-compare -Wno-unused-parameter > -Wno-type-limits -Wno-comment -Wno-missing-field-initializers > -Wno-strict-overflow -Werror". > > The fixes are mostly printf format strings, with a few uninitialized > pointers thrown in for good measure. In particular, this happened more > than once, which will fail if "something" is false and the stack garbage > initializing "p" is not NULL: > void *p; > if (something) > p = somethingMaybeReturningNull(); > if (!p) > p = somethingElse();
I would like to apply this, but the patch mixes the warning fixes with other things (like the piece in src/event.c which you had a second thought later in this thread). Can you separate the 100%-secure warning fixes from the less obvious stuff (e.g. the one which Tamas pointed out) and send them in different patches? By the same token, it would be better if you keep the po/ changes in a separate patch too. Splitting a big patch into smaller pieces with well-defined purposes makes it easier to review and access their implications. Furthermore, although it is not strongly required, it would be better if you could send the patches as described in The-perfect-Window-Maker-patch.txt. -- To unsubscribe, send mail to [email protected].
