On Sun, 29 Aug 2010 at 13:45:31 +0200, Andreas Metzler wrote:
> On 2010-08-22 "Carlos R. Mafra" <[email protected]> wrote:
> > This patch makes wmaker automatically Restart() to take into account
> > resolution changes done by xrandr.
> [...]
> > diff --git a/src/startup.c b/src/startup.c
> > index 9b63687..b16b979 100644
> > --- a/src/startup.c
> > +++ b/src/startup.c
> [...]
> > +#ifdef HAVE_XRANDR
> > +extern Bool has_randr;
> > +extern int randr_event_base;
> > +#endif
> > +
> >  /* contexts */
> [...]
> > @@ -692,6 +700,12 @@ void StartUp(Bool defaultScreenOnly)
> >     wShapeSupported = XShapeQueryExtension(dpy, &wShapeEventBase, &j);
> >  #endif
> 
> > +#ifdef HAVE_XRANDR
> > +   has_randr = XRRQueryExtension(dpy, &randr_event_base, &dummy);
> > +#else
> > +   has_randr = false;
> > +#endif
> > +
> [...]
> 
> Hello,
> This part will cause a build failure if randr is missing. has_randr is
> modified but not declared. Patch attached.

Right, thanks! I applied it to 'next' and rebased it so that your fix
is right after the RandR patch (but I did not squash it).

> I think the Debian package should be built with RandR support by
> default. - Patch attached.

Agree. In fact, the RandR stuff also does not make much sense without
xinerama. So I thought that I should make xinerama be enabled by default
too, but got lazy to do the configure.ac patch to turn --enable-xinerama
into --disable-xinerama. Any volunteers? :-)



-- 
To unsubscribe, send mail to [email protected].

Reply via email to