On Tue, 12 Oct 2010 at 8:27:33 -0400, Brad Jorsch wrote: > On Tue, Oct 12, 2010 at 10:33:40AM +0200, Carlos R. Mafra wrote: > > > > That suggests the diff below instead of your patch. It compiles here, but > > I haven't tested it. But it saves one call to WMGetFromPLDictionary() and > > accomplishes what your original patch did too, unless I am missing > > something. > > Consider what happens if adict exists but does not contain the key > "Icon".
Ok. > > It's a matter of trying to do things as cleanly as possible. And saving > > the icon everytime you open a docked app because the icon might have > > changed does not seem to be elegant, IMHO. > > I just think that never updating the cache will cause users to be confused. Right, let's leave it like that then. Would you mind re-sending the "val = NULL" patch with proper git format and your Signed-off-by:? Thanks a lot, gold Brad! -- To unsubscribe, send mail to [email protected].
