On Sat, 14 Jul 2012, Christophe escribió: > Hello, > > Following feedback from Rodolfo and Carlos, I propose a new version of the > patch. I have split the previous patches into smaller, clearer ones trying to > have explicit messages on the why and hows for each of them. > > Regards, > Christophe.
Hi Christophe, first, I didn't check all your patches, but I have two questions (for you, and for the list): 1. Why the changes are in WINGs? Probably is a good idea, but I am not sure. Probably more people can give us more info about if the changes should include WINGs. Adding things to WINGs creates new symbols,.... 2. In the patch number 1, you add the file header with the tipical "Alberto Kojima" copyright, but in the patch 4 or 5, you remove it and include your name. IMO, the copyrigth should be added, but not removed, but probably we should create a rule about this headers. Something like add the copyright to "Window Maker Devel Team", update all files, and use the AUTORS file. I will continue with the checking later. I would like to read all patches before send the comments. Thanks for your great work. Now is more easy. kix -- ||// //\\// Rodolfo "kix" Garcia ||\\// //\\ http://www.kix.es/ -- To unsubscribe, send mail to [email protected].
