----- Rodolfo García Peñas <[email protected]> a écrit : > On Sat, 14 Jul 2012, Christophe escribió: > > > Hello, > > > > Following feedback from Rodolfo and Carlos, I propose a new version of the > > patch. I have split the previous patches into smaller, clearer ones trying > > to have explicit messages on the why and hows for each of them. > > > > Regards, > > Christophe. > > Hi Christophe, > > first, I didn't check all your patches, but I have two questions (for you, > and for the list): > > 1. Why the changes are in WINGs? Probably is a good idea, but I am not sure. > Probably more people can give us more info about if the changes should > include WINGs. Adding things to WINGs creates new symbols,....
This choice was actually the result of a long reflection... I reminded that wmaker was actually not the only program to access the menus, but WPrefs.app also does! So I considered making this code available to both. After some research to look for actual shared libs (and not willing to create a new lib just for that purpose), the only place left was in WINGs; and considering this: "[WINGs]'s primary role is to support Window Maker. All other uses of it are just an added bonus" I felt it was a decent choice. > 2. In the patch number 1, you add the file header with the typical "Alberto > Kojima" copyright, but in the patch 4 or 5, you remove it and include your > name. IMO, the copyright should be added, but not removed, but probably we > should create a rule about this headers. Something like add the copyright to > "Window Maker Devel Team", update all files, and use the AUTHORS file. As path 1 keeps the original code, it'd be daring to change ownership; however in patch 5 the code is completely changed (despite git trying hard to find common lines), so it would be false to claim copyright to someone else and I updated the copyright to have something at least valid. Your "WindowMaker Dev Team" idea sounds good but I doubt lawyers would like it as in many countries it needs to be either one identified person, a _registered_ company or a _registered_ foundation. I did not think about updating AUTHORS either, but it looks a bit outdated, and I'd tease a bit by saying that you're not even in it, which is not really right considering the work you're doing here too! > I will continue with the checking later. I would like to read all patches > before send the comments. > > Thanks for your great work. Now is more easy. > > kix > -- > ||// //\\// Rodolfo "kix" Garcia > ||\\// //\\ http://www.kix.es/ -- To unsubscribe, send mail to [email protected].
