On Tue, 13 Nov 2012, BALATON Zoltan escribió:
> On Tue, 13 Nov 2012, Rodolfo García Peñas (kix) wrote:
> >there are two problems:
> >
> >1. xfig don't have the WM_ICON_NAME set, therefore the function
> >wIconPaint() don't draw the title. You can try to set the value
> >with xprop, reload windowmaker and then the title will appear in
> >xfig's icon. The update pixmap function don't paint the background
> >square because the variable titled is created using the
> >WM_ICON_NAME value too.
>
> This may be unrelated and was already discussed but as a summary
> here's what I think about this:
>
> 1. xfig does set WM_ICON_NAME (at least on my system) but it sets it
> to the name of the edited file which may be empty if "No file" is
> open. (Note that it is slightly different that the property is not
> set and it is set but has an empty string as a value.)
>
> 2. A possible fallback for missing icon name may be the WM_CLASS
> which is always set and usually shorter than say WM_NAME (which
> might also be missing and need a fallback itself) but what you do is
> up to you. I don't mind having icons without a title and so far you
> seem to be the only one annoyed by this, at least noone else said
> anything to this topic. Probably you could make a patch which allows
> using a fallback but is disabled by default and has to be enabled if
> one prefers.
>
> >2. As I said in my final mail about icons (that was not my last
> >mail about icons :-) ), the icon image and the window image are
> >different. icon image is window->icon and window image is
> >window->net_icon_image. If the user sets the icon, then the
> >selected icon is used in the window (alt+tab) and in the icon, but
> >if is not set, then the icons could be different.
>
> I couldn't really follow this and didn't check the code either. Just
> trying to test it from the users' point of view so I can't comment
> on this.
>
> >I sent a patch yesterday. The problem is that the
> >wIconValidateIconSize didn't check the width and the height size
> >for the icon, only checked one of them. The new patch check both
> >values and holds the icon aspect ratio.
>
> I've tested your patch but it didn't change anything. gtk-demo still
> has an icon which is too large for the tile and appears clipped. I
> did some more testing and found that the Apply button does not seem
> to do anything (after setting an icon I have to restart the app to
> have the icon changed) and that the Ignore client supplied icon
> option seems to work for gtk-demo but not for xfig. Don't know the
> reason for any of these just letting you know what I saw.
Yes,
I installed gtk-demo and you are right :-/
The problem is the icon is not resized.
@@ -476,6 +478,8 @@ static RImage *get_wwindow_image_from_wmhints(WWindow
*wwin, WIcon *icon)
(hints->flags & IconMaskHint)
? hints->icon_mask : None);
+ image = wIconValidateIconSize(image, wPreferences.icon_size);
+
return image;
}
I will check tomorrow the other methods to create icons, to check if they
include the icon size validation.
Anyway, I am so happy with the new code, because as you can see, is more easy,
but yes, some things could be better. Alt+tab show a correct icon too.
Thanks A LOT for your report.
kix
PS. The patch I sent yesterday is ok too. You can test it with xcalc, the icon
without that patch is not correctly painted.
PS2. I will reply your other questions tomorrow.
> Regards,
> BALATON Zoltan
--
To unsubscribe, send mail to [email protected].
