>>>>> "CRM" == Carlos R Mafra <[email protected]> writes:

    CRM>> The coding style of the patch must be changed to match the
    CRM>> rest.  See http://windowmaker.org/dev.php

I absolutely agree.

    CRM>> But I'm a bit worried about code duplication. Adding the
    CRM>> function trimstr() does not seem a good idea - there's
    CRM>> wtrimspace() in WINGs. I didn't look at the rest closely.

I'm not the author of this patch, I just adapted it to apply to new
WindowMaker. I don't know much internals of WindowMaker, might someone
who familiar with WindowMaker code base would make a code audit.

-- 
Ignorantia iuris nocet


-- 
To unsubscribe, send mail to [email protected].

Reply via email to