On Fri, 30 Mar 2012 at 10:57:20 +0300, Yuri Karaban wrote: > > CRM>> But I'm a bit worried about code duplication. Adding the > CRM>> function trimstr() does not seem a good idea - there's > CRM>> wtrimspace() in WINGs. I didn't look at the rest closely. > > I'm not the author of this patch, I just adapted it to apply to new > WindowMaker. I don't know much internals of WindowMaker, might someone > who familiar with WindowMaker code base would make a code audit.
I understand that you are not the original author. But unfortunately that doesn't matter much in this case, because the patch adds code which will probably have to cleaned up somehow later - the trimstr() function was the easiest to detect case. As this patch duplicates code and (to a smaller degree) functionality - why not use the root menu shortcuts directly? - I don't think it has a strong appeal right now. -- To unsubscribe, send mail to [email protected].
