On Fri, 07 Dec 2012, Milan Čermák escribió: > Hi, > first of all, thanks for accepting my patch for wmtime. > Now, I'd like to submit another patch - for wmSMPmon dockapp this time. > I wanted to use it on Solaris which has different way to obtain > system statistics. I build a support file and changed Makefile to > take the operating system into account. > Then I moved to fixing the widget. The comments in the code said > that it supports only 2 CPUs. I've added an aggregation so that it > still shows two graphs but represents all CPUs. > Lastly, I some programmatic flaws - like multiple loops for one task > - cleaning up the code a bit. It should also speed up the widget a > little. > > I'd be happy to do more clean-ups (and get rid of that french > naming). Any comments are welcome. > > Cheers, > Milan
Hi Milan, nice work. I cannot check your code at this moment, but reading your patch I have two comments: - You are using sometimes spaces, sometimes tabs. IMO is better use the same character in the code. - Some curly brackets in the "for" loops can be removed, because there is only one line in the block. OTOH, if you want, probably you can split this patch in two. One patch with the code cleaning and other with the new features. Is better to understand the code. I do it often (send the patches with all together :-) ). Cheers, kix -- ||// //\\// Rodolfo "kix" Garcia ||\\// //\\ http://www.kix.es/ -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
