On Fri, 7 Dec 2012 at 21:48:42 +0100, Rodolfo García Peñas wrote: > > OTOH, if you want, probably you can split this patch in two. One patch > with the code cleaning and other with the new features. Is better to > understand the code.
Yes. I agree that if you do that it's better. Even better would be if you use git and send the patches in the format of 'git format-patch', so that I can apply it immediately and do not need to do copy & paste to get the authorship right from the email headers etc. But having said that, the dockapp repo is more relaxed regarding coding style (there's none) and the rule about one patch for one logical change only. But if someone wants to do some serious work which will modify the dockapp significantly, I strongly suggest to follow Rodolfo's advice above. Simply because it will make things easier in case one change breaks something. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
