On Thu, 18 Apr 2013 at 0:10:12 -0300, Renan Traba wrote: > simplified logic of handleMaximize function
You should write a separate patch for this item alone. > added maximize on top and bottom half and added maximize at 4 corners: > left top, right top, left bottom, right bottom ditto. > removed unneeded old_maximize flags ditto. > added to WPrefs options to configure new maximize modes ditto. > --- > WPrefs.app/KeyboardShortcuts.c | 12 ++ > src/actions.c | 253 > ++++++++++++++++------------------------- > src/actions.h | 8 +- > src/defaults.c | 12 ++ > src/event.c | 42 +++++++ > src/keybind.h | 8 +- > src/window.h | 3 +- > 7 files changed, 175 insertions(+), 163 deletions(-) Since otherwise the patch is big and if a regression is found it is much harder to revert it. And even more importantly, did you address the comments by Iain? If so, that should be mentioned too. If not, please explain the reason. Is it really necessary to rewrite the handleMaximize() logic in order to add the left/right top/bottom maximize? If not, I'd suggest that your first patches should simply add the new functionality and only the later patches should rewrite the logic. -- To unsubscribe, send mail to [email protected].
