2013/4/18 Carlos R. Mafra <crma...@gmail.com> > > simplified logic of handleMaximize function > > You should write a separate patch for this item alone. >
I will do it > > > added maximize on top and bottom half and added maximize at 4 corners: > > left top, right top, left bottom, right bottom > > ditto. > agreed, I will separate these > > > removed unneeded old_maximize flags > I removed it because my new logic dont need it > > > added to WPrefs options to configure new maximize modes > > ditto. I will separate this one too > > Since otherwise the patch is big and if a regression is found it is much > harder to revert it. > > And even more importantly, did you address the comments by Iain? If so, > that should be mentioned too. If not, please explain the reason. > > Is it really necessary to rewrite the handleMaximize() logic in order > to add the left/right top/bottom maximize? If not, I'd suggest that > your first patches should simply add the new functionality and only > the later patches should rewrite the logic. > I only managed to add these after I rewrite the logic, the old logic was lot confuse to me :(, so I need to rewrite the logic first > > > -- > To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org. > -- Renan Vedovato Traba Aluno de Bacharelado em Ciência da Computação pela Universidade Federal do Paraná Linux Register n°: 525911
