----- Rodolfo García Peñas <k...@kix.es> a écrit :
> On Sat, 05 Oct 2013, Carlos R. Mafra escribió:
>
> > On Sat, 5 Oct 2013 at 0:53:52 +0200, Christophe wrote:
> > >
> > > ----- Rodolfo García Peñas (kix) <k...@kix.es> a écrit :
> > > > The new struct wks_info includes the global information
> > > > for the workspaces. All information related with the workspaces
> > > > should be included here.
> > > >
> > > > The first variable moved is workspace_name_font, included in this
> > > > patch. This variable was included in the screen info, but the
> > > > screen and the font used in the workspace name don't have any
> > > > relationship.
> > > >
> > > > Signed-off-by: Rodolfo García Peñas (kix) <k...@kix.es>
> > > > ---
> > > > [...]
> > > >
> > > > diff --git a/src/workspace.h b/src/workspace.h
> > > > index 69d1b18..68cd275 100644
> > > > --- a/src/workspace.h
> > > > +++ b/src/workspace.h
> > > > @@ -23,12 +23,16 @@
> > > > #define WMWORKSPACE_H_
> > > >
> > > >
> > > > -
> > > > typedef struct WWorkspace {
> > > > char *name;
> > > > struct WDock *clip;
> > > > } WWorkspace;
> > > >
> > > > +typedef struct WWorkspace_info {
> > > > + /* Workspace stuff */
> > > > + WMFont *workspace_name_font;
> > > > +} WWorkspace_info;
> > > > +
> > >
> > > Hi,
> > >
> > > May I suggest, as this is a global variable, to place it the the global
> > > structure instead? You could define something like:
> > >
> > > struct {
> > > WMFont *font_for_name;
> > > } workspace;
> > >
> > > and put it somewhere around src/WindowMaker.h:483
> > > That way, the variable would be accessed via:
> > > w_global.workspace.font_for_name
> > > which would make it look a bit more expressive from my point of view.
> >
> > That's a good idea.
>
> I wrote these patches three times. These patches were before the Christophe
> patches, with the new variable scheme. It is frustrating.
>
Hi,
I totally understand this, these patch look already like a lot of good work!
I propose my help on this, with the constraint that I will probably not be able
to do it this busy weekend, so I may not be able to submit updated patches
before next week.
> Other patches are uploaded with wrong style, with c++ comments, with compiler
> warnings, without commit info,... I am trying to upload these patches because
> I have a lot of patches here with more stuff, and I am waiting for them to
> continue, but no.
>
> I am tired, bored. Good nigth.
> --
--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
