On Sun, 25 May 2014 at 11:40:06 +0200, Josip Deanovic wrote: > Quoting message written on Monday 2013-11-11 22:22:01 by Josip Deanovic: > > Hi everyone! > > > > Here is another oversight I have noticed in the process of my transition > > from 0.80.2 to the latest Windowmaker. > > > > If you open three windows and shade one of them and then try to focus > > next window using ALT+TAB or whatever combination of keys you prefer > > for window cycling using keyboard, you would notice that shaded window > > never gets focus. > > > > In my opinion shaded window should get a focus in the situation as > > described above and I have two arguments in favor of this opinion: > > > > 1. It is the behavior of the Windowmaker 0.80.2 and earlier versions. > > 2. It's intuitive and helpful solution or should I say that any other > > solution in this case would make it harder/slower to find your shaded > > window under two or three other windows. I am used to use ALT+TAB to > > quickly rise all or just few of the windows, including those which are > > shaded and give them a focus and unshade them if needed. > > > > I guess that the original behavior was lost at the time of adding > > windows-like bar that shows window icons wile cycling trough the list of > > stacked windows. > > Good thing that there is an option "SwitchPanelImages = None" because it > > makes to much distraction for my taste. > > > Greetings, > > I finally got some time to check the windowmaker code (from the next > branch) and to fix the issue reported above. > > Please consider applying the patch below. > It would make the focus of the shaded windows to work/behave the same as > windowmaker 0.80.2. I have tested the patch with and without switchpannel > and it looks ok. > > Without this patch cycling trough the list of mapped windows would never > focus shaded windows thus leaving them hidden under bunch of other windows. > > > > --- wmaker-crm/src/actions.c 2014-05-25 10:28:14.000000000 +0200 > +++ wmaker-crm.new/src/actions.c 2014-05-25 11:23:21.000000000 +0200 > @@ -234,11 +234,6 @@ > > wwin->flags.skip_next_animation = 0; > wwin->flags.shaded = 1; > - wwin->flags.mapped = 0; > - /* prevent window withdrawal when getting UnmapNotify */ > - XSelectInput(dpy, wwin->client_win, wwin->event_mask & > ~StructureNotifyMask); > - XUnmapWindow(dpy, wwin->client_win); > - XSelectInput(dpy, wwin->client_win, wwin->event_mask); > > /* for the client it's just like iconification */ > wFrameWindowResize(wwin->frame, wwin->frame->core->width, > wwin->frame->top_width - 1);
I cannot apply this. Just checking the chronology of development I don't understand how removing the above lines can fix your problem. You said that wmaker-0.80.2 works for you, but the above lines are _much_ older than that: e7495baf (dan 1999-02-17 11:06:40 +0000 273) wwin->flags.mapped = 0; ^9d2e6ef (scottc 1998-09-29 22:36:29 +0000 274) /* prevent window withdrawal when getting UnmapNotify */ 84576113 (dan 2003-07-16 20:58:49 +0000 275) XSelectInput(dpy, wwin->client_win, e7495baf (dan 1999-02-17 11:06:40 +0000 276) wwin->event_mask & ~Structure NotifyMask); ^9d2e6ef (scottc 1998-09-29 22:36:29 +0000 277) XUnmapWindow(dpy, wwin->client_win); e7495baf (dan 1999-02-17 11:06:40 +0000 278) XSelectInput(dpy, wwin->client_win, wwin->event_mask); The commit from 1998 is actually the first in the git history. So I think that the patch is just hides some other issue. Both Amadeusz and Zoltan confirm that your issue is related to setting "SwitchPanelImages = None". And this patch doesn't explain why that happens. Since you have the git repository, you can 'git bisect' the issue to find the real cause of your bug and fix this properly. It will probably have something to do with the SwitchPanelImages setting. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
