"Carlos R. Mafra" <[email protected]> escribió:
On Mon, 8 Dec 2014 at 17:46:25 +0000, Rodolfo García Peñas (kix) wrote:
"Carlos R. Mafra" <[email protected]> escribió:
>On Mon, 8 Dec 2014 at 16:28:14 +0100, Rodolfo García Peñas wrote:
>>On Mon, 08 Dec 2014, Carlos R. Mafra escribió:
>>
>>> On Mon, 8 Dec 2014 at 13:36:25 +0100, Rodolfo García Peñas wrote:
>>> > Hi,
>>> >
>>> > I have a question about the variable "nopolling". Is used?
>>Could we remove it?
>>> >
>>> > I found it in src/startup.c, but the variable is never set.
>>I am missing something?
>>> >
>>> > Thanks,
>>> > kix
>>> >
>>> > kix@debian:~/src/wmaker/awmaker$ rgrep nopolling *
>>> > NEWS:Running Window Maker with one of -nopolling or
>>--no-polling command line
>>> > src/startup.c: if (!wPreferences.flags.nopolling &&
>>!wPreferences.flags.noupdates)
>>> > src/WindowMaker.h: unsigned int nopolling:1;
>>/* don't poll the defaults database for changes */
>>> > kix@debian:~/src/wmaker/awmaker$
>>>
>>> [mafra@linux-g29b:wmaker.git]$ git grep -B 2 nopolling
>>> NEWS----------------------------------
>>> NEWS-
>>> NEWS:Running Window Maker with one of -nopolling or
>>--no-polling command line
>>> --
>>> src/WindowMaker.h- unsigned int norestore:1;
>>/* don't restore session */
>>> src/WindowMaker.h-#ifndef HAVE_INOTIFY
>>> src/WindowMaker.h: unsigned int nopolling:1;
>>/* don't poll the defaults database f
>>> or changes */
>>> --
>>> src/startup.c-#ifndef HAVE_INOTIFY
>>> src/startup.c- /* setup defaults file polling */
>>> src/startup.c: if (!wPreferences.flags.nopolling &&
>>!wPreferences.flags.noupdates)
>>> [mafra@linux-g29b:wmaker.git]$
>>
>>Yes, but the variable is never set, therefore the "if" in
>>src/startup.c is always true. IMO we can remove this variable.
>
>I see. The issue here seems to be that the command line option
"--no-polling"
>sets the variable noupdates instead of nopolling (see src/main.c).
>
>In principle these two variables should be distinct, I'm not sure
>if we can actually merge the two concepts.
Hi,
the feature was added here:
http://repo.or.cz/w/wmaker-crm.git/commit/4637c09d19570050158851109d9df92e3c18db58
And removed here:
http://repo.or.cz/w/wmaker-crm.git/commitdiff/722c82c8ab50f3f6efe62b5897a69547c04e0f81
Do you remember something about this patch?
I do. In the commit 722c82c8 I removed the variable completely.
Commit c7868fa4 added it back but made the -no-polling option set
the noupdates variable instead of nopolling. Perhaps that was not
intended.
Ok, but in your oppinion what is the better way to finish with this point?
Rodolfo García Peñas (kix)
http://www.kix.es/
--
To unsubscribe, send mail to [email protected].
