On Friday 2015-08-14 11:06:16 Doug Torrance wrote: > On 08/14/2015 10:48 AM, Alexey I. Froloff wrote: > > On Thu, Aug 13, 2015 at 05:42:41PM +0200, Rodolfo García Peñas (kix) wrote: > >> This patch includes the library wmgeneral. > > > > Please, don't do it! There's already libdockapp, why would we > > need yet another _shared_ library with, like, five functions? > > What are you trying to fix? Does it really worth it? You only > > make things harder for a package maintainers. > > > > Better rewrite those applets to libdockapp. > > Speaking as the package maintainer for ~30 dockapps in Debian, I think > this is a great idea and makes it easier for me, not harder. > > For example, dockapps that use wmgeneral/list.c were recently not able > to compile with gcc5, and I've had to fix this individually in all my > wmgeneral dockapps in Debian. If the shared library had already > existed, I wouldn't have had to touch these packages individually and > just the library could have been updated. > > Certainly there would be the initial headache of packaging wmgeneral and > changing some lines of code in each dockapp to use the new library, but > it seems worth it to me. > > As far as there being two libraries, wmgeneral is by far more common. I > believe there's around 13 in the dockapps git repository that use it, > but only one or two that use libdockapp. It would be a lot of work to > port them all. On the other hand, I think libdockapp has a better, > more intuitive interface. > > Just my two cents, > Doug > > P.S. On a related note, I'd like to add the new library to the dockapps > portion of the website, but we need a version number to create a git tag > for my script to work. I suppose libwmgeneral-1.0 would be fine?
I don't remember that I have ever had to compile wmgeneral library for the dockapps I am using but I might be wrong. On the other hand I am sure that some of the dockapps I am using depend on the libdockapp (e.g. wmnetload). -- Josip Deanovic -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
