"Alexey I. Froloff" <ra...@raorn.name> escribió:
On Thu, Aug 13, 2015 at 05:42:41PM +0200, Rodolfo García Peñas (kix) wrote:
This patch includes the library wmgeneral.
Please, don't do it! There's already libdockapp, why would we
need yet another _shared_ library with, like, five functions?
What are you trying to fix? Does it really worth it? You only
make things harder for a package maintainers.
Better rewrite those applets to libdockapp.
Hi Alexey,
both, wmgeneral and libdockapp are used in a lot of applications:
kix@kentin:~/src/dockapps$ rgrep wmgeneral * | cut -d/ -f1 | uniq -c
| grep -v binar
1 dockapps.db.in:This app is based on the wmgeneral code."
105 libwmgeneral
57 wmbiff
4 wmCalClock
12 wmckgmail
10 wmcpufreq
14 wmfsm
13 wmifs
8 wmitime
10 wmkeys
4 wmmon
2 wmnotify
1 wmpower
11 wmppp.app
8 wmsm.app
5 wmSMPmon
7 wmsun
43 wmtime
5 wmtv
10 wmtz
2 wmWeather
kix@kentin:~/src/dockapps$ rgrep libdockapp * | cut -d/ -f1 | uniq -c
| grep -v binar | grep -v dockapps
26 libdockapp
14 wmacpi
2 wmacpiload
2 wmbatteries
2 wmcalendar
1 wmclock
10 wmcpuload
2 wmmemload
1 wmmenu
3 wmpower
5 wmwifi
kix@kentin:~/src/dockapps$
Probably we should join both libraries in only one, but now, why do
not create the libwmgeneral lib? There are more dockapps using
libwmgeneral than libdockapp.
As Doug said, with the new gcc version we need change a lot of
dockapps, and this is the reason to create this library.
The patch about the library is easy to include in the repo, we can
update all dockapps using wmgeneral, remove the wmgenal folders and
update the code.
IMO is better have only one library than the same code in 20 different
dockapps/folders.
Cheers,
kix
Rodolfo García Peñas (kix)
http://www.kix.es/
--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
