[ 
https://issues.apache.org/jira/browse/WODEN-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12513939
 ] 

Dan Harvey commented on WODEN-141:
----------------------------------

As only one TypesElement can exist in a DescriptionElement in the WSDL 2.0 Spec 
the createTypesElement() factory method has to decide what to do if a 
TypesElement already exists in the DescriptionElement.

I have agreed with John that we will just replace the existing TypesElement if 
createTypesElement() is called and have put this behaviour in the JavaDoc 
comment for the createTypesElement() method interface.

> DescriptionElement.getTypesElement() should not be a factory method
> -------------------------------------------------------------------
>
>                 Key: WODEN-141
>                 URL: https://issues.apache.org/jira/browse/WODEN-141
>             Project: Woden
>          Issue Type: Bug
>          Components: Parser
>            Reporter: John Kaputin
>            Assignee: John Kaputin
>             Fix For: M8
>
>
> The behaviour of the DescriptionElement.getTypesElement() method is to return 
> the types element if it exists or if not, create it and return it.  This 
> means that the model can never reflect an infoset that does not have a 
> <wsdl:types> element because this getter method will always create one even 
> if there isn't one in the WSDL. 
> Instead, this method should return null if there is no types element and a 
> new factory method is required - createTypesElement(), which will create a 
> TypesElement, set the DescriptionElement as its parent and return a reference 
> to it. This is similar behaviour to the addXXXXElement methods that create 
> sets of child elements, except that it acts on a single types element only 
> (hence the method name 'create' rather than 'add').

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to