[
https://issues.apache.org/jira/browse/WODEN-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514628
]
Dan Harvey commented on WODEN-141:
----------------------------------
#1 Yes.
#2 If you've agreed createXXX should not have side-effects then addXXX should
be used and more consistent with the rest of the class.
#3 In keeping with the word add and the way the rest of the class uses it we
should never overwrite or remove old TypesElements, so that would be a good way
to do it.
If no one disagrees I'll create the changes in the way Jeremy described above.
> DescriptionElement.getTypesElement() should not be a factory method
> -------------------------------------------------------------------
>
> Key: WODEN-141
> URL: https://issues.apache.org/jira/browse/WODEN-141
> Project: Woden
> Issue Type: Bug
> Components: Parser
> Reporter: John Kaputin
> Assignee: John Kaputin
> Fix For: M8
>
>
> The behaviour of the DescriptionElement.getTypesElement() method is to return
> the types element if it exists or if not, create it and return it. This
> means that the model can never reflect an infoset that does not have a
> <wsdl:types> element because this getter method will always create one even
> if there isn't one in the WSDL.
> Instead, this method should return null if there is no types element and a
> new factory method is required - createTypesElement(), which will create a
> TypesElement, set the DescriptionElement as its parent and return a reference
> to it. This is similar behaviour to the addXXXXElement methods that create
> sets of child elements, except that it acts on a single types element only
> (hence the method name 'create' rather than 'add').
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
