2009/10/22 Gavin <[email protected]>: > > >> -----Original Message----- >> From: [email protected] [mailto:[email protected]] On >> Behalf Of Ross Gardler >> Sent: Thursday, 22 October 2009 1:22 AM >> To: wookie-dev >> Subject: commit messages >> >> We need to set commit messages to come to this list (Gavin, do you >> have the necessary foo for this?) > > Yes, however, I spotted a wee config error. When I created the lists > initially I also created a commits list (it wasn't asked for but I > pre-empted). So, that's the first thing, devs will need to subscribe to > [email protected] to start receiving them.
Hmmm.... I'm -1 on a commit specific list, that's why, as champion, I did not ask for one. There is, in my opinion, no sense in splitting commit messages from the developer list. All developers should be reading commit messages (commit then review) and we should not make it easy for people to avoid this responsibility - especially in an incubating project. There may come a day where the volume of commits or discussion makes it sensible to split the lists, but I do not believe that day is today. Ross > > The error is in the fact it is a moderated list, with me as mod, and hence > found all the commits waiting in my mod box. They are all now approved have > have flowed into the commits list, so theres a bit of good news, no commits > lost. > > I'll do a switcheroo on the list so I don't need to mod it soon. > > Gav... > >> >> In the meantime, it is clear that the commit messages are not >> including the issue number from where the patch is retrieved. i.e. >> "WOOKIE-26" >> >> It is important to do this because it creates the IP trail for >> contributions. From the commit message we can see the issue, from the >> issue we can see the contributor agreed for it to be included in the >> project. >> >> Another important reason is that JIRA picks this up and records it in >> the comments. >> >> Whilst on the topic of commit messages they should also include the >> name of the original contributor, e.g. "applied patch to fix broken >> foobar (WOOKIE-34). Thanks to Jane Bloggs." >> >> This is so that the contributor gets credited and also so that we can >> track people contributions with a simple search of the mail archives >> (once the commit to mail bridge is set up). >> >> Ross >> >> -- >> Ross Gardler >> >> OSS Watch - supporting open source in education and research >> http://www.oss-watch.ac.uk >> No virus found in this incoming message. >> Checked by AVG - www.avg.com >> Version: 8.5.422 / Virus Database: 270.14.23/2447 - Release Date: 10/20/09 >> 18:42:00 > > -- Ross Gardler OSS Watch - supporting open source in education and research http://www.oss-watch.ac.uk
