Hi Bill, I understand what your saying. I kind of like svn -qv status wsjt.py as it spits out the 4 pieces of info that's relevant, repo revision, file revision, modified by and file name. I'm not so worried about local mods, as I would never publish anything form a local build tree that didn't come from SVN first.
This whole things doesn't really need to happen on JTSDK-PY, but it keeps the source tree clean after running cx_freeze. We could just as easily run InnoSet after cx_freeze from the src directory and forgo the whole install directory move in the first place. The Makefile will contain the major version information anyway, it's only added a reference point in the final Windows Installer file name like ( wsjt10-Win32-r4227.exe ) or similar. I don't see the point in sticking r4255 on a file / folder for a script that it's last change was r4227. Thus the reason I think svn status is a good compromise. It's it 100% correct, maybe not from a purest standpoint, but it's certainly useful. 73's Greg, KI7MT On 9/6/2014 19:40, Bill Somerville wrote: > On 06/09/2014 19:53, KI7MT wrote: >> Hi Bill, > Hi Greg, >> >> Yes, understand. The method needs to be changed in the build scripts. >> Both wsjt.py and wspr.py have svn propset and the $Id in the file. >> >> Using svn info at the HEAD of each folder yields the repository version >> as expected (r4255), however, we can always grab the Last Changed >> field(s) of a file if that's desired: >> >> --> svn info wsjt.py |grep "Last Changed" >> Last Changed Author: k1jt >> Last Changed Rev: 4227 >> Last Changed Date: 2014-08-05 13:54:34 +0000 (Tue, 05 Aug 2014) >> >> Which matches what is hard coded rev in the wsjt.py file. The main files >> for those two apps are the wsjt.py and wspr.py. > OK, but svnversion is explicitly designed to get the workspace revision > for builds and documentation and contains extra information if there are > local changes or mixed revisions synchronized. It is the only "correct" > way to determine the revision of a workspace. >> >> 73's >> Greg, KI7MT > 73 > Bill > G4WJS. >> >> >> On 9/6/2014 18:13, Bill Somerville wrote: >>> On 06/09/2014 19:04, KI7MT wrote: >>>> Hi Sandro, >>> Hi Sandro & Greg, >>>> Nice work. I'll add that to all the env scripts just to be sure. >>> The normal way to determine the revision of an SVN workspace is to use >>> the 'svnversion -qn' command. Extracting a revision number from an >>> expanded "$Reveision:$" keyword in a source file is not a good way to do >>> this because the revision number is only the last change of that file >>> rather than the actual revision the workspace is synchronized to. >>> >>> Also this mechanism is locale neutral and avoids the main issue of this >>> thread. >>>> 73's >>>> Greg, KI7MT >>> 73 & Hope This Helps >>> Bill >>> G4WJS. >>>> On 9/6/2014 10:57, IW3RAB - Alessandro Gorobey wrote: >>>>> KI7MT <ki7mt@...> writes: >>>>> >>>>>> Hi Sandro, >>>>>> >>>>>> I'm not sure why your having that situation. Using the file is not best >>>>>> way to get the revision, if anything changes, it gets busted. Maybe >>>>>> there is a DOS/*Nix translation happening or something, other than that, >>>>>> I'm not sure why the extra space is in there. >>>>>> >>>>>> 73's >>>>>> Greg, KI7MT >>>>>> >>>>> ----------------------------------------------- >>>>> CUTTED >>>>> ---------------------------------------------- >>>>> Hi Greg, >>>>> problem solved >>>>> >>>>> I use windows7home ITALIAN >>>>> >>>>> If I http to sourceforge.net I can see only the file present on server, >>>>> not >>>>> the SVN version downloaded by svn client >>>>> >>>>> The SVN used in the exceptional JTSDK is language compiliant. >>>>> This is explained in the manual section "keyword sobstitution" >>>>> So if I go to C:\JTSDK-PY\subversion\bin and do the command >>>>> svn --version >>>>> I obtain the ITALIAN printout. >>>>> >>>>> The program is sensitive to LANG settings. >>>>> So: >>>>> C:\JTSDK-PY\jtsdk-pyenv.bat >>>>> set LANG=en_US >>>>> >>>>> solve problem >>>>> >>>>> Seems that only wsjt.py suffers the problem >>>>> In JTSDK-QT I not found any $Date svn keywords. >>>>> >>>>> The LANG accepts all valid values as in *NIX systems. >>>>> >>>>> Seem I am the first "LANG"!="en_US" >>>>> >>>>> >>>>> 73's >>>>> >>>>> Sandro IW3RAB >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> Slashdot TV. >>>>> Video for Nerds. Stuff that matters. >>>>> http://tv.slashdot.org/ >>>>> _______________________________________________ >>>>> wsjt-devel mailing list >>>>> wsjt-devel@lists.sourceforge.net >>>>> https://lists.sourceforge.net/lists/listinfo/wsjt-devel >>>>> >>> >>> ------------------------------------------------------------------------------ >>> Slashdot TV. >>> Video for Nerds. Stuff that matters. >>> http://tv.slashdot.org/ >>> _______________________________________________ >>> wsjt-devel mailing list >>> wsjt-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/wsjt-devel >>> > > > ------------------------------------------------------------------------------ > Slashdot TV. > Video for Nerds. Stuff that matters. > http://tv.slashdot.org/ > _______________________________________________ > wsjt-devel mailing list > wsjt-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wsjt-devel > -- 73's Greg, KI7MT ------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/ _______________________________________________ wsjt-devel mailing list wsjt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wsjt-devel
