Hi, two more problems which have been spotted during the WSJT-X package Fedora review [1] and I think it's worth to report upstream:
- GUIcontrols.txt, prefixes.txt, wsjtx_changelog.txt all have CR + LF line endings - jt9 binary has executable stack 73! Jaroslav, OK2JRQ [1] https://bugzilla.redhat.com/show_bug.cgi?id=1487776 ----- Original Message ----- > FYI, WSJT-X Fedora review request: > https://bugzilla.redhat.com/show_bug.cgi?id=1487776 > > I am attaching patch which I had to use. I think it could be beneficial > for other distros as well, so please consider it's inclusion upstream > (it shouldn't break the current behavior), it does the following: > > - it makes Boost_NO_SYSTEM_PATHS user settable, allowing users to compile > with the system boost *1) > - it makes hamlib_STATIC user settable, allowing user to link dynamically > with the hamlib *2) > - it allows compilation with the stock (i.e. not forked hamlib) *3) > - it allows compilation with the boost version 1.60 *4) > > *1) In Fedora (and probably in other distro's as well) it's not allowed > to bundle, everything needs to be compiled with the system libraries and > system headers, so having support upstream for such approach would be great. > > *2) In Fedora (and probably others) it's not allowed to statically link, > so having switch for dynamic linking would also help. > > *3) In Fedora due to *1) and *2) we cannot use the forked hamlib. > So I think it would be beneficial to support compilation with both > versions of hamlib. I.e. forked hamlib - full functionality, non-forked > hamlib - limited functionality, but no compilation errors or third party > patching needed. > > *4) I would like to introduce the wsjtx package to older Fedora versions > as well. I tried and it compiled OK with the boost 1.60 and so far it > also seems to work OK with it, so maybe 1.60 is enough. > > 73! Jaroslav, OK2JRQ > > > ----- Original Message ----- > > RR, good idea! -- Joe, K1JT > > > > On 8/31/2017 7:31 PM, Jaroslav Skarvada wrote: > > > Hi Joe, > > > > > > thanks for info. I have WSJT-X packaging on my todo list, but I didn't > > > know > > > that it completely superseded WSPR-X. But no problem, I will probaly > > > close > > > the WSPR-X inclusion request and will open new one for WSJT-X > > > > > > 73! Jaroslav, OK2JRQ > > > > > > > > > ----- Original Message ----- > > >> Hi Jaroslav, > > >> > > >> Thanks for your email. I wish I could have saved you the effort already > > >> put into this task, because I do not recommend packaging WSPR-X for any > > >> platform or distribution. WSPR-X is obsolete, and no longer supported. > > >> Its functions are limited, and anyway now much better served by WSJT-X. > > >> > > >> -- 73, Joe, K1JT > > >> > > >> On 8/31/2017 5:39 PM, Jaroslav Skarvada wrote: > > >>> Hi, > > >>> > > >>> I am trying to get WSPR-X into Fedora [1]. > > >>> > > >>> During the packaging I have found few issues: > > >>> > > >>> - I had to apply the attached patch in order to compile the > > >>> code under Fedora, otherwise it wanted to link with the palir-02.dll > > >>> > > >>> - in the SVN few source files had executable permission set > > >>> > > >>> - files in SVN have mixed line endings, most of the files have LF, > > >>> but there are also files with CR + LF ending > > >>> > > >>> - I wasn't sure which version the WSPR-X is, for the SVN revision > > >>> 8046 the GUI app shows 0.9, but there is written 1.3 in the > > >>> CMakeLists.txt, so I marked it as SVN snapshot after the 0.9 release. > > >>> > > >>> - during the build it created empty /usr/bin/kvasd file, so I didn't > > >>> package it > > >>> > > >>> - the provided icon is very small (only 32 x 32 pixels), it would > > >>> be great to have 128 x 128 pixels PNG at least. If you don't have > > >>> resources to create it, I think our design team could help > > >>> > > >>> - it's missing .desktop file, I created one (in attachment) > > >>> > > >>> 73! Jaroslav, OK2JRQ > > >>> > > >>> [1] https://bugzilla.redhat.com/show_bug.cgi?id=1487419 > > >>> > > >>> > > >>> > > >>> ------------------------------------------------------------------------------ > > >>> Check out the vibrant tech community on one of the world's most > > >>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > >>> > > >>> > > >>> > > >>> _______________________________________________ > > >>> wsjt-devel mailing list > > >>> [email protected] > > >>> https://lists.sourceforge.net/lists/listinfo/wsjt-devel > > >>> > > >> > > > > > > ------------------------------------------------------------------------------ > > > Check out the vibrant tech community on one of the world's most > > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > > _______________________________________________ > > > wsjt-devel mailing list > > > [email protected] > > > https://lists.sourceforge.net/lists/listinfo/wsjt-devel > > > > > > > ------------------------------------------------------------------------------ > > Check out the vibrant tech community on one of the world's most > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > _______________________________________________ > > wsjt-devel mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/wsjt-devel > > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > wsjt-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/wsjt-devel > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ wsjt-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wsjt-devel
