What I said was the valgrind does NOT show a memory leak on a single run of 
jt9.exeI'm not able to run valgrind on wsjtx on my VM...
I don't know if you have a Unix system to test but the jt9 process under Ubuntu 
is leaking memory quite considerably as has already been reported by Doug 
VE7GNU.
It's not as visible under Windows.
I traced the problem down to four2a.f90.   If that one routine was not called 
the memory leaks reduced very noticeably (and I am referring to LONG term 
memory leaks).  I then noticed destroying the plans every time also reduced the 
loss.  
And yeah...you can see the short delay at the start of decode....so I guess 
I'll have to keep diving deeper to find out where this is happening.
Probably ought to create a process like Qt is doing to use the shared memory so 
could test it better/faster.
Mike


 

    On Tuesday, February 27, 2018, 4:27:04 PM CST, Bill Somerville 
<g4...@classdesign.com> wrote:  
 
  On 27/02/2018 22:09, Black Michael via wsjt-devel wrote:
  
 This patch solves at least part of the memory leak problem seen with jt9.exe 
running under WSJT-X control.  jt9 happily passes valgrind checks running 
standalone.  It's the looping of jt9a causing problems. 
  In Windows you'll now see the memory usage go up and down whereas before it 
would only go up. 
  https://www.dropbox.com/s/mhnqzepw1fvbtt3/jt9a.patch?dl=1
  
  
 
HI Mike,
 
that change is de-optimizing the FFT plan caching and should not be needed. The 
creation of FFTW3 processing plans is an expensive step and they are carefully 
preserved across decoding passes for good reason. Any memory accumulated is not 
a leak as the plans created will surely be reused in later decoding passes.
 
I am surprised that valgrind is identifying leaks for FFT plans, can you share 
a leak report showing that please?
 
 
73
 Bill
 G4WJS.

  ------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! 
http://sdm.link/slashdot_______________________________________________
wsjt-devel mailing list
wsjt-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wsjt-devel
  
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
wsjt-devel mailing list
wsjt-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wsjt-devel

Reply via email to