Thanks for the warm welcome everyone. I finally got patches for these two issues pushed into Gerrit. Actually, I filed a new Bugzilla ticket for the latter issue since there wasn't one yet.
I've never used Gerrit before. I assume it will send an email when action is needed (code defects, etc.)? 363580 - RhinoRemote debugger can not find the thread because it's too quick and it's finished before the RhinoRequest arrives. https://bugs.eclipse.org/bugs/show_bug.cgi?id=363580 https://git.eclipse.org/r/63683 485301 - Files shown in 'External JavaScriptSource' can be the wrong file https://bugs.eclipse.org/bugs/show_bug.cgi?id=485301 https://git.eclipse.org/r/63785 On Fri, Dec 25, 2015 at 11:18 AM, Victor V. Rubezhny <vrubez...@exadel.com> wrote: > Philip, > > That's great! Thank you for your fix proposals! > > Have good holidays! > > Kind Regards, > Victor Rubezhny, > JSDT > > > On 12/25/2015 07:13 PM, Philip Lowman wrote: > > Mickael, > > Thanks for the pointers, compiling with Java 8 solved the problem. > > I'll signup for an Eclipse account and push my patches via Gerrit soon. > One is for bug 363580 > <https://bugs.eclipse.org/bugs/show_bug.cgi?id=363580> to prevent the > debugger from resuming all threads when Context.enter() & exit is called > without starting a script thread (a very common use case for us). The > other is a bug having to do with collisions in generated filenames in the > External Javascript Source folder (which prevents opening the correct > source file when it happens). > > > On Wed, Dec 23, 2015 at 4:55 AM, Mickael Istria <mist...@redhat.com> > wrote: > >> On 12/23/2015 04:40 AM, Philip Lowman wrote: >> >> Hi, >> >> Hi, >> >> I've developed a couple of fixes for the javascript debugger >> >> Great! >> Thanks and welcome! >> >> 1. If I need to be concerned with the following build error for the >> org.eclipse.wst.jsdt.doc plugin[1] which I get after following the >> directions at the URL below. The error message sounds like I should be >> compiling with the Java EE SDK. Should I be compiling with the Java EE SDK >> or is it acceptable to just disable this plugin and develop with the Java >> SE SDK? >> >> https://wiki.eclipse.org/JSDT/Development#Building_and_testing_JSDT_locally >> >> osgi.ee means "OSGi Execution Environment", which is configured per >> bundle in the Bundle-RequiredExecutionEnvironment directlve in the >> MANIFEST.MF. It's not related to Java EE. >> Those errors seem to highlight that you're using Java 7, whereas most >> recent Eclipse bundles require Java 8. So I believe you should simply >> install Java 8 and make sure you have it well configured for the build to >> use it. "mvn --help" can be used to tell you which version of Java your >> build is using. >> >> 2. Directions on how to contribute fixes. What is the preferred process >> for JSDT? Is it to sign the agreement referenced on this page and just >> attach patches to Bugzilla (filing bugs when necessary)? >> https://eclipse.org/contribute/ >> >> The most efficient and recommended workflow is to push your patches via >> Gerrit: >> https://wiki.eclipse.org/JSDT/Development#Pushing_a_new_patch_for_review >> >> HTH >> -- >> Mickael Istria >> Eclipse developer at JBoss, by Red Hat <http://www.jboss.org/tools> >> My blog <http://mickaelistria.wordpress.com> - My Tweets >> <http://twitter.com/mickaelistria> >> >> _______________________________________________ >> wtp-dev mailing list >> wtp-dev@eclipse.org >> To change your delivery options, retrieve your password, or unsubscribe >> from this list, visit >> https://dev.eclipse.org/mailman/listinfo/wtp-dev >> > > > > -- > Philip Lowman > > > _______________________________________________ > wtp-dev mailing listwtp-...@eclipse.org > To change your delivery options, retrieve your password, or unsubscribe from > this list, visithttps://dev.eclipse.org/mailman/listinfo/wtp-dev > > > > CONFIDENTIALITY NOTICE: This email and files attached to it are > confidential. If you are not the intended recipient you are hereby notified > that using, copying, distributing or taking any action in reliance on the > contents of this information is strictly prohibited. If you have received > this email in error please notify the sender and delete this email. > > _______________________________________________ > wtp-dev mailing list > wtp-dev@eclipse.org > To change your delivery options, retrieve your password, or unsubscribe > from this list, visit > https://dev.eclipse.org/mailman/listinfo/wtp-dev > -- Philip Lowman
_______________________________________________ wtp-dev mailing list wtp-dev@eclipse.org To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/wtp-dev
