Sorry this took so long to integrate. My bad.
The changes are now committed. Please check the integration carefully.
I made one small change. In SAX2DTM m_sourceSystemId, m_sourceLine, and
m_sourceColumn were being automatically created by the variable
initializers. I took this out since they are being recreated in
setProperty anyway, and aren't otherwise being used unless
"http://xml.apache.org/xalan/properties/source-location"; is set to true.
The creation of a SAX2DTM needs to be kept fairly cheap since SAX2DTMs are
also used for result tree fragments, so we don't want create objects if we
don't have to.
Clearly Transformer#setProperty should be added to JAXP 1.2. I tried for
1.1 but got vetoed.
> if (m_sourceSystemId.size() != m_size) {
> System.out.println("size array " + m_size
> + " is different from size of array "
> + m_sourceSystemId.size());
> System.exit(1);
> }
I know this is an assert rather than exception handling, but I really
dislike having System.exits in the code. Do you have a strong opinion
about this? I would personally rather see a runtime exception here.
Thanks for the great addition!!!
-scott
