On Wed, 11 Jul 2001 00:19:43 -0400, [EMAIL PROTECTED] wrote:
> Sorry this took so long to integrate. My bad.
No problem, I saw you were really busy last week.
> The changes are now committed. Please check the integration carefully.
Yep, I'll do that.
> I made one small change. In SAX2DTM m_sourceSystemId, m_sourceLine, and
> m_sourceColumn were being automatically created by the variable
> initializers. I took this out since they are being recreated in
> setProperty anyway, and aren't otherwise being used unless
> "http://xml.apache.org/xalan/properties/source-location"; is set to true.
> The creation of a SAX2DTM needs to be kept fairly cheap since SAX2DTMs are
> also used for result tree fragments, so we don't want create objects if we
> don't have to.
Makes sense.
> Clearly Transformer#setProperty should be added to JAXP 1.2. I tried for
> 1.1 but got vetoed.
I agree with you. Saxon has a similar way of setting properties to
Transformer. I'm wondering whether we should have some predefined
properties defined in JAXP that could be set on a transformer. It
would be nice to try to avoid the situation where different
implementations provide different names for similar properties (like
line numbers).
> > if (m_sourceSystemId.size() != m_size) {
> > System.out.println("size array " + m_size
> > + " is different from size of array "
> > + m_sourceSystemId.size());
> > System.exit(1);
> > }
>
> I know this is an assert rather than exception handling, but I really
> dislike having System.exits in the code. Do you have a strong opinion
> about this? I would personally rather see a runtime exception here.
Yes, this should be a runtime exception. It may have been late in the
night when I wrote that code. Please let me know whether you want to
do the change and provide a patch, or you take care of it.
> Thanks for the great addition!!!
You're more than welcome!
Regards,
Ovidiu
--
Ovidiu Predescu <[EMAIL PROTECTED]>
http://orion.nsr.hp.com/ (inside HP's firewall only)
http://sourceforge.net/users/ovidiu/ (my SourceForge page)
http://www.geocities.com/SiliconValley/Monitor/7464/ (GNU, Emacs, other stuff)
