to start with the following libs are available as modules from xbmc repo
and should be added as dependency and imported as such:
bs4
pyamf
simplejson

You use the pluginpath for storing information. This is not allowed and the
profile path should be used.

xbmc.translatePath(xbmcaddon.Addon().getAddonInfo('profile')).decode('utf-8')


also throughout the code i found things that have nothing to do with this
addon and are copied from

"plugin.video.free.cable-beta"

or something. Please clean up as this makes reviewing the code a lot of
work and imo not acceptable as such.
Like
https://github.com/learningit/plugin.video.si/blob/master/resources/lib/_common.py
has almost nothing to do with this addon.


As a separate note:
if would also be better if the other libs are made separate modules as
well: html5lib and dns (if they are still needed)

regards,
Martijn Kaijser
Team XBMC


On Fri, Dec 6, 2013 at 8:36 PM, scotty roscoe <scottyrosco...@gmail.com>wrote:

>
> Sorry wrong version in previous request v1.0.0 is correct
>
>  *addon -   plugin.video.si
>  *version - 1.0.0
>  *url - https://github.com/learningit/plugin.video. 
> <https://github.com/learningit/plugin.video.wsj>si
>  *revision - 24b40f55b79c18ca140a5c4741954f9a77ce764f
>  *branch - master
>  *xbmc version - frodo
>
>
>
>
>
> ------------------------------------------------------------------------------
> Sponsored by Intel(R) XDK
> Develop, test and display web and hybrid apps with a single code base.
> Download it for free now!
>
> http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk
> _______________________________________________
> Xbmc-addons mailing list
> Xbmc-addons@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>
>
------------------------------------------------------------------------------
Sponsored by Intel(R) XDK 
Develop, test and display web and hybrid apps with a single code base.
Download it for free now!
http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk
_______________________________________________
Xbmc-addons mailing list
Xbmc-addons@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xbmc-addons

Reply via email to