On 08-09-14 08:09, Cooper Beilby wrote:
> * addon - skin.eminence
> * version - 0.9.55
> * url - https://github.com/jurialmunkey/skin.eminence
> * revision - 2c5647975f2b64b564a0ccbcae668f513b393663
> * branch - master
> * xbmc version - Gotham
>
hey Cooper,
thanx a bunch for submitting your skin to the addon repo!
as with all new skin submissions, it's gonna take a bit of effort to fix
up the initial issues.
it often takes a couple of rounds to get everything into shape and ready
for repo inclusion.
i've done some checkups on the code and came up with a list of things
that require your attention:
1) please remove the TODO file
2) in addon.xml,
- set xbmc.gui to 5.0.1
- add a 'lang' attribute to the summary / description tags (eg. <summary
lang="en">...)
3) images in the _screenshots folder have to be 1280x720px
4) case sensitive issue:
colors\Defaults.xml > colors\defaults.xml
5) use <onleft>noop</onleft> instead of <onleft>-</onleft>. the same
applies to onright / onup / ondown
1080i/DialogButtonMenu.xml: <onleft>-</onleft>
1080i/SettingsProfile.xml: <onleft>-</onleft>
1080i/SettingsProfile.xml: <onleft>-</onleft>
1080i/SettingsProfile.xml: <onleft>-</onleft>
1080i/VisualisationPresetList.xml: <onleft>-</onleft>
1080i/DialogButtonMenu.xml: <onright>-</onright>
1080i/SettingsProfile.xml: <onright>-</onright>
1080i/SettingsProfile.xml: <onright>-</onright>
1080i/SettingsProfile.xml: <onright>-</onright>
1080i/VisualisationPresetList.xml: <onright>-</onright>
1080i/MusicOSD.xml: <onup>-</onup>
1080i/SettingsProfile.xml: <onup>-</onup>
1080i/VideoOSD.xml: <onup>-</onup>
1080i/DialogAddonSettings.xml: <onup>-</onup>
1080i/Includes_OSD.xml: <onup>-</onup>
1080i/Includes_OSD.xml: <onup>-</onup>
1080i/Includes_OSD.xml: <onup>-</onup>
1080i/DialogSlider.xml: <onup>-</onup>
1080i/MusicOSD.xml: <ondown>-</ondown>
1080i/SettingsProfile.xml: <ondown>-</ondown>
1080i/VideoOSD.xml: <ondown>-</ondown>
1080i/VideoOSD.xml: <ondown>-</ondown>
1080i/Includes_OSD.xml: <ondown>-</ondown>
1080i/Includes_OSD.xml: <ondown>-</ondown>
1080i/Includes_OSD.xml: <ondown>-</ondown>
1080i/SettingsCategory.xml: <ondown>-</ondown>
1080i/DialogSlider.xml: <ondown>-</ondown>
6) the following files are marked as executable, please remove the
executable bit:
./fonts/SourceSansPro-Bold.ttf
./fonts/SourceSansPro-Black.ttf
./fonts/Weather.ttf
./fonts/SourceSansPro-Regular.ttf
./fonts/LICENSE-WeatherFont.txt
7) these files styart with a BOM character, please remove the BOM from
the beginning of the files:
./1080i/DialogNetworkSetup.xml
./1080i/Custom_WidgetHub.xml
./1080i/Custom_Hub_TV.xml
./1080i/Custom_SetItem.xml
./1080i/Custom_SetSpecialItem.xml
./1080i/DialogYesNo.xml
./1080i/Startup.xml
./1080i/Custom_SetHub.xml
./1080i/Custom_SetWidget.xml
./1080i/DialogProgress.xml
./1080i/script-NextAired-TVGuide.xml
./1080i/DialogOK.xml
./1080i/DialogSeekBar.xml
./1080i/Custom_Debug_Overlay.xml
./1080i/Custom_Hub_Music.xml
./1080i/Custom_Hub_PVR.xml
./1080i/Custom_SetGlobalWidget.xml
./1080i/DialogContextMenu.xml
./1080i/script-NextAired-TVGuide2.xml
./1080i/MusicOSD.xml
./1080i/Custom_Rss.xml
./1080i/DialogSubtitles.xml
./1080i/script-globalsearch-contextmenu.xml
./1080i/Custom_SetHome.xml
./1080i/DialogFullScreenInfo.xml
./1080i/Custom_SetMove.xml
./1080i/Custom_Hub_Movies.xml
./1080i/Custom_SetColor.xml
8) please use unix style eol's:
fonts/LICENSE-SourceSansPro.txt: Windows (CRLF)
fonts/LICENSE-WeatherFont.txt: Windows (CRLF)
LICENSE: Windows (CRLF)
9) invalid xml:
missing space between border and colordiffuse:
./1080i/SmartPlaylistEditor.xml:42.41: Couldn't find end of Start Tag
texturefocus
<texturefocus
border="12"colordiffuse="PosterHighlight">comm
./1080i/SkinSettings.xml:65.44: Couldn't find end of Start Tag
alttexturefocus
<alttexturefocus
border="12"colordiffuse="PosterHighlight">c
./1080i/DialogContentSettings.xml:118.37: Couldn't find end of Start Tag
texturefocus
<texturefocus
border="12"colordiffuse="PosterHighlight">common/w
./1080i/MyMusicPlaylistEditor.xml:61.50: Couldn't find end of Start Tag
texture
<texture border="12"
flipx="false"colordiffuse="Post
./1080i/DialogPVRTimerSettings.xml:33.36: Couldn't find end of Start Tag
texture
<texture
border="12"colordiffuse="PosterHighlight">common/wh
./1080i/MyWeather.xml:61.49: Couldn't find end of Start Tag animation
<animation effect="fade" start="100" end="25"
time="200"conditio
./1080i/SettingsProfile.xml:17.36: Couldn't find end of Start Tag texture
<texture
border="12"colordiffuse="PosterHighlight">common/wh
./1080i/RecordPrefs.xml:24.36: Couldn't find end of Start Tag texture
<texture
border="12"colordiffuse="PosterHighlight">common/wh
./1080i/DialogPVRChannelManager.xml:200.45: Couldn't find end of Start
Tag texturefocus
<texturefocus
border="12"colordiffuse="PosterHighlight">
./1080i/LockSettings.xml:19.36: Couldn't find end of Start Tag texture
<texture
border="12"colordiffuse="PosterHighlight">common/wh
./1080i/Settings.xml:42.41: Couldn't find end of Start Tag texturefocus
<texturefocus
border="12"colordiffuse="PosterHighlight">comm
./1080i/FileManager.xml:71.50: Couldn't find end of Start Tag texture
<texture border="12"
flipx="false"colordiffuse="Post
./1080i/Includes_NextAired.xml:131.43: Couldn't find end of Start Tag
texturenofocus
<texturenofocus
border="12"colordiffuse="PosterHighlight">co
./1080i/DialogMediaFilter.xml:29.36: Couldn't find end of Start Tag texture
<texture
border="12"colordiffuse="PosterHighlight">common/wh
./1080i/ProfileSettings.xml:17.36: Couldn't find end of Start Tag texture
<texture
border="12"colordiffuse="PosterHighlight">common/wh
./1080i/Includes_Defs.xml:520.29: Couldn't find end of Start Tag
texturefocus
<texturefocus
border="12"colordiffuse="PosterHighlight">common/white.png
./1080i/DialogAddonSettings.xml:49.37: Couldn't find end of Start Tag
texturefocus
<texturefocus
border="12"colordiffuse="PosterHighlight">common/w
./1080i/DialogSelect.xml:52.36: Couldn't find end of Start Tag texture
<texture
border="12"colordiffuse="PosterHighlight">common/wh
./1080i/DialogMediaSource.xml:54.41: Couldn't find end of Start Tag
texturefocus
<texturefocus
border="12"colordiffuse="PosterHighlight">comm
./1080i/View_50_List.xml:88.54: Couldn't find end of Start Tag texture
<texture border="12"
flipx="false"colordiffuse="
./1080i/SmartPlaylistRule.xml:38.37: Couldn't find end of Start Tag
texturefocus
<texturefocus
border="12"colordiffuse="PosterHighlight">common/w
./1080i/DialogPVRGuideSearch.xml:43.41: Couldn't find end of Start Tag
texturefocus
<texturefocus
border="12"colordiffuse="PosterHighlight">comm
./1080i/View_PVR.xml:396.40: Couldn't find end of Start Tag texture
<texture
border="12"colordiffuse="PosterHighlight">commo
./1080i/DeleteTimer.xml:24.36: Couldn't find end of Start Tag texture
<texture
border="12"colordiffuse="PosterHighlight">common/wh
./1080i/SettingsCategory.xml:122.33: Couldn't find end of Start Tag
texturefocus
<texturefocus
border="12"colordiffuse="PosterHighlight">common/white
use & instead of &
./1080i/Includes_Hub.xml:57.73: EntityRef: expecting ';'
<onclick>RunScript(script.globalsearch,tvshows=true&episodes=true&mo
comments can only have two hypens: <!-- --> no more, no less.
./1080i/Includes_OSD.xml: lines 3 & 5
<!------------------->
if you could please fix those issues. :-)
should you have any questions or need any help, don't hesitate to ask !
cheers,
ronie
------------------------------------------------------------------------------
Want excitement?
Manually upgrade your production database.
When you want reliability, choose Perforce.
Perforce version control. Predictably reliable.
http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
