On 10-09-14 04:31, Cooper Beilby wrote:
Hi Ronie,

I think I have managed to correct all these issues. Have a look and let me know of anything else I need to address. Also note that I will need the eminence functions script (https://github.com/jurialmunkey/script.eminencefunctions) as a dependency which I have also submitted for inclusion in the addon repo. Thanks :)
* addon - skin.eminence
* version - 0.9.57
* url - https://github.com/jurialmunkey/skin.eminence
* revision - a24f864b666f652721fafe499301e37c6aa4be38
* branch - master
* xbmc version - Gotham

Regards,
Cooper.


hey Cooper,

thanx for the quick fixes.
here's a list of remaining issues i came across:


1) you can now remove this file:
colors\Defaults.xml


2) your skin is missing two required files:
DialogSongInfo.xml
VideoOverlay.xml


3) invalid xml:
./1080i/MyWeather.xml: line 60 - missing space
<animation effect="fade" start="100" end="25" time="200"conditio


./1080i/Custom_SetGlobalWidget.xml: lines 129 & 169 - use &amp;
widget.path,plugin://service.library.data.provider?type=recommendedmovies&reload


./1080i/Custom_SetWidget.xml: lines 130 & 170 - use &amp;
,.bgwidget],plugin://service.library.data.provider?type=recommendedmovies&reload


4) unmatched parenthesis:
Includes_OSD.xml: <onup condition="IsEmpty(Window(seekbar).Property(fullscreeninfo) + VideoPlayer.IsFullscreen">SetProperty(fullscreeninfo,1,seekbar)</onup> Includes_OSD.xml: <onup condition="!IsEmpty(Window(seekbar).Property(fullscreeninfo) + VideoPlayer.IsFullscreen">ClearProperty(fullscreeninfo,seekbar)</onup> Includes_OSD.xml: <ondown condition="!IsEmpty(Window(seekbar).Property(fullscreeninfo) + VideoPlayer.IsFullscreen">ClearProperty(fullscreeninfo,seekbar)</ondown> Includes_OSD.xml: <ondown condition="[IsEmpty(Window(seekbar).Property(fullscreeninfo) + VideoPlayer.IsFullscreen] | !VideoPlayer.IsFullscreen">Close</ondown> Includes_OSD.xml: <onclick condition="IsEmpty(Window(seekbar).Property(fullscreeninfo)">SetProperty(fullscreeninfo,1,seekbar)</onclick> Includes_OSD.xml: <onclick condition="!IsEmpty(Window(seekbar).Property(fullscreeninfo)">ClearProperty(fullscreeninfo,seekbar)</onclick> Includes_OSD.xml: <onclick condition="IsEmpty(Window(seekbar).Property(fullscreeninfo)">SetProperty(fullscreeninfo,1,seekbar)</onclick> Includes_OSD.xml: <onclick condition="!IsEmpty(Window(seekbar).Property(fullscreeninfo)">ClearProperty(fullscreeninfo,seekbar)</onclick> Includes_OSD.xml: <onclick condition="IsEmpty(Window(seekbar).Property(fullscreeninfo)">SetProperty(fullscreeninfo,1,seekbar)</onclick> Includes_OSD.xml: <onclick condition="!IsEmpty(Window(seekbar).Property(fullscreeninfo)">ClearProperty(fullscreeninfo,seekbar)</onclick>


5) Undefined ID's:
Undefined ID: 9502
Includes_Defs.xml: <visible allowhiddenfocus="true">![Control.HasFocus(9500) | Control.HasFocus(9501) | Control.HasFocus(9502) | ControlGroup(300).HasFocus()]</visible> Includes_WindowContent.xml: <value condition="![Control.HasFocus(9500) | Control.HasFocus(9502) | Control.HasFocus(9501)] + !IsEmpty(ListItem.Art(fanart))">$INFO[ListItem.Art(fanart)]</value> Includes_WindowContent.xml: <value condition="![Control.HasFocus(9500) | Control.HasFocus(9502) | Control.HasFocus(9501)] + !IsEmpty(ListItem.Property(Fanart_Image))">$INFO[ListItem.Property


Undefined ID: 108
Includes_Labels.xml: <value condition="Control.HasFocus(108) | Window.IsActive(pvrsettings)">$LOCALIZE[19020]</value>


Undefined ID: 350
Includes_Defs.xml: <visible allowhiddenfocus="true">![Control.HasFocus(9500) | Control.HasFocus(9501) | Control.HasFocus(9502) | ControlGroup(300).HasFocus()]</visible> Includes_WindowContent.xml: <value condition="![Control.HasFocus(9500) | Control.HasFocus(9502) | Control.HasFocus(9501)] + !IsEmpty(ListItem.Art(fanart))">$INFO[ListItem.Art(fanart)]</value> Includes_WindowContent.xml: <value condition="![Control.HasFocus(9500) | Control.HasFocus(9502) | Control.HasFocus(9501)] + !IsEmpty(ListItem.Property(Fanart_Image))">$INFO[ListItem.Property


cheers,
ronie
------------------------------------------------------------------------------
Want excitement?
Manually upgrade your production database.
When you want reliability, choose Perforce
Perforce version control. Predictably reliable.
http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons

Reply via email to