Isn't all this stuff used by Tk as well? Or does Tk code not use those callbacks at all?
Anyway, I've fixed it all up in my version of the code. Cheers, Kuba On Sep 29, 2010, at 9:34 AM, Tim Edwards wrote: > Dear Kuba, > >> The zoominrefresh(int,int) and zoomoutrefresh(int,int) have wrong signatures >> and cannot >> be directly invoked as Xt callbacks. They need shims that first get the >> mouse pointer position >> and then invoke those. >> There are possibly more problems like that, although only some of them >> result in wrong >> application behavior, even if they all depend on unspecified behavior per >> the C standard. >> It was generally a bad idea that there were function pointer coercions done >> in the [0,set,tool]action >> macros in menus.h. This code should be cleanly compiling without any >> coercions; the function >> signatures need fixing etc. > > I've said it before, and I'll say it again: I have not used the Xt > version of xcircuit for years, and I haven't compiled it in over a > year. I have, in places, streamlined the code for Tcl/Tk at the > expense of the Xt version, which I have undoubtedly broken in places. > I used to go to some length to make sure that both versions were in > working condition, but I eventually stopped doing that, unless > somebody gives me feedback about a problem. > > I admit that the function coercions are an ugly hack. I am an open- > source developer in the traditional sense: I write code for my own > purposes, and if anybody else wants to use it, that's just great. > However, that also means that I leave it to people like you to clean > up the messes I sometimes (often) leave behind. Believe me, I've > done a lot of cleaning up of other programmers' ugly messes, myself. > > ---Tim > > +--------------------------------+-------------------------------------+ > | Dr. R. Timothy Edwards (Tim) | email: [email protected] | > | Open Circuit Design, Inc. | web: http://opencircuitdesign.com | > | 22815 Timber Creek Lane | phone: (301) 528-5030 | > | Clarksburg, MD 20871-4001 | cell: (240) 401-0616 | > +--------------------------------+-------------------------------------+ _______________________________________________ Xcircuit-dev mailing list [email protected] http://www.opencircuitdesign.com/mailman/listinfo/xcircuit-dev
