On Sep 29, 2010, at 9:34 AM, Tim Edwards wrote:

> Dear Kuba,
> 
>> The zoominrefresh(int,int) and zoomoutrefresh(int,int) have wrong signatures 
>> and cannot
>> be directly invoked as Xt callbacks. They need shims that first get the 
>> mouse pointer position
>> and then invoke those.
>> There are possibly more problems like that, although only some of them 
>> result in wrong
>> application behavior, even if they all depend on unspecified behavior per 
>> the C standard.
>> It was generally a bad idea that there were function pointer coercions done 
>> in the [0,set,tool]action
>> macros in menus.h. This code should be cleanly compiling without any 
>> coercions; the function
>> signatures need fixing etc.
> 
> I've said it before, and I'll say it again:  I have not used the Xt
> version of xcircuit for years, and I haven't compiled it in over a
> year.

Since you asked for bug reports, I'm merely sending what I find. It's all fixed 
in my copy of the code.

I'll be soon starting up a google code project for this to make it easier for 
others to contribute -- once
it'll be sorta-kinda-working, that is.

Cheers, Kuba
_______________________________________________
Xcircuit-dev mailing list
[email protected]
http://www.opencircuitdesign.com/mailman/listinfo/xcircuit-dev

Reply via email to