hmmmm... oops, I'm guessing you're seeing my cvs logs coming through (o: On Fri, 12 Oct 2001, Ara Abrahamian wrote:
> Cleaner but more verbose. Xdt +1 true, ok > SubTask won't derive from TemplateEngine. Why should it? Will it use > anything from template engine? No, everything is done in tagimpl > classes, the only thing it should do is to new it and call > setblabla/start() methods of template engine. It's semantically > incorrect to derive subtask to derive from template engine. > TemplateEngine is not final but not extended in own system by any class. yeah, looking at your class diagram I can see what you're saying. A reference to TemplateEngine is much better > No! We're processing template file blabla.j, so current class/method/etc > is valid only for the scope of that template file. We can place > curmethod/class/etc in TemplateEngine as is now, but what does a parser > has to do with current class in a javadoc tree? Nothing. A single > instance of Xdocletcontext is shared by all subtasks and tagimpls, so > not a good place to put a current-template-scope variable there. The > best place is subtask I think. And because tagimpls have a back pointer > to subtask there's no problem there. yeah, I think a lot of the things I've looked at are very similar, but different approaches... you diagram looks a lot cleaner than whats in my head, so I think that what I've just checked in can happily be dumped. Unfortunately I have next to zero international bandwidth atm, so I'm not really in much of a position to be exchanging code and stuff... but I'm keen to work through this. fyi I'm in Sydney (GMT+10), and will probably get into this tomorrow morning (about 10-12 hours away). Now that I've got your class diagram, if you make a start, then I can work of a TODO list if you want to do it that way... if not, when I start tomorrow I'll work off the class diagram as best I can.... let me know > Btw, I strongly suggest you to use IDEA for the huge refactoring we > should do :-) emacs (o: Although I would be keen to try it, heard a lot of good things, but I wouldn't want to try it unless I'm in a position to buy, which I'm not atm )o: cheers dim _______________________________________________ Xdoclet-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/xdoclet-devel
