On Sat, 13 Oct 2001, Ara Abrahamian wrote: > > What now needs to be done is all the methods that are used in the > various > > subclasses of SubTask need to be migrated to new implementations of > > XDocletTagSupport, mappings created in the xdoclet-mappings.properties > > file, and the templates changed. > > Slow down man! We'll simply move some template tags to their new home > and move the rest when we're sure the system works as expected.
ok - cool. fine by me. The only thing this will still leave is at some point a change from "<XDt" to "<Xdt" assuming you still want that, and to remove the logic that looks at both tag prefixes. Should be an easy bulk replace and change. > > Yep seems to be backward compatible I think, though it's not a priority > at all, it's even not needed! We are the only guys who coded it the old > way and we'll update our codes. > The grouping you suggested is ok, we should deal with each case by case. > yeah, it was getting late, and I was fading and didn't want to start doing a heap of stuff > > btw - I did some fairly heavy refactorings on TemplateEngine.generate > > because the first time I did this I got a bug... so I went back and > > started from scratch, but refactored first because of the size of that > > generate method. Have a look at it and let me know what you think. > > There is still more that could be done, but I think it looks a lot > > more readable. > > I'm against such refactorings! Don't enter new factors, just let us > concentrate on namespace refactoring, later we'll refactor generate too. > Code little, test little I mean. I'm going to argue here (o: off-topic and all, but... here's what I did. 1. Made the changes directly 2. Introduced bug 3. Spent an hour looking for the bug 4. Gave up looking for bug and started from scratch 5. Refactored 6. Tested 7. Repeated 6 & 7 several times 8. Made changes to refactored code 9. Introduced bug 10. Found bug in 2 minutes and from the man himself (Fowler): Refactor When You Add Function The most common time to refactor is when I want to add a new feature to some software.... anyway, I'm assuming you're happy with the end result (of the refactoring specifically), just not the process (o: > Anyway, I didn't find time yesterday, I'll start working on it tonight, > haven't even looked at it actually :-) got your other email now, am waiting. cheesr dim _______________________________________________ Xdoclet-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/xdoclet-devel
