On 2002.12.29 04:56:49 -0500 Erik Hatcher wrote:
> How about leveraging the -propertyfile command-line switch instead of  
> constructing -D arguments?  You'd then just pass the path to a property  
> file and properties with spaces would pass through fine.

Indeed that would be better.  Is there an easy way or example I can crib to
write all the properties to a file?

On a more basic level, is there some reason the GrandModulesBuilderTask is
calling ant by executing a command line rather than using the ant task to
execute in-vm?????  It seems to me that it might make more sense to either
change the code to do this or to write out a build.xml doing this and then
call ant on it.

thanks
david jencks
> 
>       Erik
> 
> 
> On Sunday, December 29, 2002, at 12:48  AM, David Jencks wrote:
> 
> > Update of /cvsroot/xdoclet/xdoclet/core/src/xdoclet/ant/modulesbuilder
> > In directory  
> > sc8-pr-cvs1:/tmp/cvs-serv12563/xdoclet/core/src/xdoclet/ant/ 
> > modulesbuilder
> >
> > Modified Files:
> >     ModulesGrandBuilderTask.java
> > Log Message:
> > Only copy properties without spaces so as to not mess up windows  
> > command lines.  Patch from Adrian Brock
> >
> > Index: ModulesGrandBuilderTask.java
> > ===================================================================
> > RCS file:  
> > /cvsroot/xdoclet/xdoclet/core/src/xdoclet/ant/modulesbuilder/ 
> > ModulesGrandBuilderTask.java,v
> > retrieving revision 1.10
> > retrieving revision 1.11
> > diff -C2 -r1.10 -r1.11
> > *** ModulesGrandBuilderTask.java    20 Dec 2002 16:49:10
> -0000 1.10
> > --- ModulesGrandBuilderTask.java    29 Dec 2002 05:48:22
> -0000 1.11
> > ***************
> > *** 290,294 ****
> >               String value = props.get(arg).toString();
> >
> > !             cmdl.createArgument().setValue("-D" + arg + "=" + value);
> >           }
> >
> > --- 290,300 ----
> >               String value = props.get(arg).toString();
> >
> > !             //don't try to set a property if it will mess up a  
> > windows command line due to spaces.
> > !             //Patch by Adrian Brock.
> > !             if (value == null || value.indexOf(" ") == -1) {
> > !                 cmdl.createArgument().setValue("-D" + arg + "=" +  
> > value);
> > !             }
> > !             // end of if ()
> > !
> >           }
> >
> >
> >
> >
> > -------------------------------------------------------
> > This sf.net email is sponsored by:ThinkGeek
> > Welcome to geek heaven.
> > http://thinkgeek.com/sf
> > _______________________________________________
> > Xdoclet-devel mailing list
> > [EMAIL PROTECTED]
> > https://lists.sourceforge.net/lists/listinfo/xdoclet-devel
> >
> 
> 
> 


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
Xdoclet-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/xdoclet-devel

Reply via email to