Well, then we should save the file in the temp dir and on *nix some ppl would be in trouble. We've had complains about xdoclet 1.1.x's temp file. Imho this patch is ok, let's see if any one complains.
Ara. > -----Original Message----- > From: [EMAIL PROTECTED] [mailto:xdoclet-devel- > [EMAIL PROTECTED]] On Behalf Of Erik Hatcher > Sent: Sunday, December 29, 2002 1:27 PM > To: David Jencks > Cc: [EMAIL PROTECTED] > Subject: Re: [Xdoclet-devel] CVS: > xdoclet/core/src/xdoclet/ant/modulesbuilder > ModulesGrandBuilderTask.java,1.10,1.11 > > How about leveraging the -propertyfile command-line switch instead of > constructing -D arguments? You'd then just pass the path to a property > file and properties with spaces would pass through fine. > > Erik > > > On Sunday, December 29, 2002, at 12:48 AM, David Jencks wrote: > > > Update of /cvsroot/xdoclet/xdoclet/core/src/xdoclet/ant/modulesbuilder > > In directory > > sc8-pr-cvs1:/tmp/cvs-serv12563/xdoclet/core/src/xdoclet/ant/ > > modulesbuilder > > > > Modified Files: > > ModulesGrandBuilderTask.java > > Log Message: > > Only copy properties without spaces so as to not mess up windows > > command lines. Patch from Adrian Brock > > > > Index: ModulesGrandBuilderTask.java > > =================================================================== > > RCS file: > > /cvsroot/xdoclet/xdoclet/core/src/xdoclet/ant/modulesbuilder/ > > ModulesGrandBuilderTask.java,v > > retrieving revision 1.10 > > retrieving revision 1.11 > > diff -C2 -r1.10 -r1.11 > > *** ModulesGrandBuilderTask.java 20 Dec 2002 16:49:10 -0000 1.10 > > --- ModulesGrandBuilderTask.java 29 Dec 2002 05:48:22 -0000 1.11 > > *************** > > *** 290,294 **** > > String value = props.get(arg).toString(); > > > > ! cmdl.createArgument().setValue("-D" + arg + "=" + value); > > } > > > > --- 290,300 ---- > > String value = props.get(arg).toString(); > > > > ! //don't try to set a property if it will mess up a > > windows command line due to spaces. > > ! //Patch by Adrian Brock. > > ! if (value == null || value.indexOf(" ") == -1) { > > ! cmdl.createArgument().setValue("-D" + arg + "=" + > > value); > > ! } > > ! // end of if () > > ! > > } > > > > > > > > > > ------------------------------------------------------- > > This sf.net email is sponsored by:ThinkGeek > > Welcome to geek heaven. > > http://thinkgeek.com/sf > > _______________________________________________ > > Xdoclet-devel mailing list > > [EMAIL PROTECTED] > > https://lists.sourceforge.net/lists/listinfo/xdoclet-devel > > > > > > ------------------------------------------------------- > This sf.net email is sponsored by:ThinkGeek > Welcome to geek heaven. > http://thinkgeek.com/sf > _______________________________________________ > Xdoclet-devel mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/xdoclet-devel ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ Xdoclet-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/xdoclet-devel
