On Thu, 2005-03-03 at 21:17, Ward, Tyler wrote: > As a result, I made the following changes. > ... > 4) All returned [Collection|Set]s are > Collections.unmodifiable[Collection|Set](...). > 5) Added get*Collection() method that returns unmodifiable [Collection|Set] > of the relations.
UnmodifiableCollection is part of the Apache commons-collections library, isn't it? I don't think we should introduce dependencies on third-party libraries in generated code, unless it's optional (e.g. a config parameter or @ejb.value-object use-unmodifiable-collections="true" parameter, defaulting to false). For some things it's appropriate (it's a no-brainer that the Struts jar is required to compile generated Struts form beans), but while we might use commons-collections to run XDoclet that doesn't mean we should force people to use it to compile their own (and generated) code. Andrew. ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ xdoclet-devel mailing list xdoclet-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xdoclet-devel
