On Tue, 2014-11-18 at 17:15 +0000, Julien Grall wrote: > > + default: > > + /* Ignore unknown PCI busses */ > > I would add a > printk("Ignoring PCI busses %s\n", dt_node_full_name(dev)); > > > + ret = 0; > > + break; > > continue?
Yes, that makes sense (probably the ret = is then unnecessary). > You can't assume the order of the PCI busses in the device tree. But, I don't understand what this has to do with using continue. > > > + } > > + > > + if ( ret < 0 ) > > + return ret; > > + > > + printk("Mapped additional regions for PCIe device at > > 0x%"PRIx64"\n", > > + addr); > > Printing the device tree path would be more helpful than the address. OK. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel