Robert Ho writes ("[PATCH OSSTEST 01/12] Add support of parsing grub which has 'submenu' primitive"): > From a hvm kernel build from Linux stable Kernel tree, > the auto generated grub2 menu will have 'submenu' primitive, upon the > 'menuentry' items. Xen boot entries will be grouped into a submenu. This > patch adds capability to support such grub formats. Also, this patch adjust > some indent alignments.
Thanks for this submission. Dealing with submenus is definitely something we want to do. I haven't looked at the code in detail yet but I have a general question: we currently count menu entries and eventually write GRUB_DEFAULT=<some number> into /etc/default/grub. Does this work properly if the entry is in a submenu ? I guess you have probably tested this but I thought I should ask... Can you please not adjust the whitespace ? osstest in general doesn't have a requirement for any particular whitespace use, and certainly if there are to be any whitespace changes they ought to be in a separate patch. Thanks, Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel