Wei Liu writes ("[PATCH v5 18/24] libxl: disallow memory relocation when vNUMA is enabled"): > Disallow memory relocation when vNUMA is enabled, because relocated > memory ends up off node. Further more, even if we dynamically expand > node coverage in hvmloader, low memory and high memory may reside > in different physical nodes, blindly relocating low memory to high > memory gives us a sub-optimal configuration. ... > "%d", > - > b_info->device_model_version==LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN_TRADITIONAL); > + > b_info->device_model_version==LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN_TRADITIONAL > && > + !b_info->num_vnuma_nodes);
I think it would be useful to add a helper function libxl__vnuma_configured() to replace all these open-coded !b_info calls etc. That will make things easier if the vnuma specification arrangements change, and it will make the code more readable too I think. Thanks, Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel