>>> On 14.08.17 at 11:07, <jgr...@suse.com> wrote: > On 14/08/17 10:39, Jan Beulich wrote: >>>>> On 14.08.17 at 09:08, <jgr...@suse.com> wrote: >>> With _cmdline_parse() now issuing error messages in case of illegal >>> parameters signalled by parsing functions specified in custom_param() >>> some messages issued by parse_low_crashinfo() and >>> parse_crashinfo_maxaddr() can be removed. >> >> But you realize this results in less information being conveyed >> (the defaults being fallen back to)? > > Yes. I guess it is a matter of taste which messages to keep. You will > have noticed I kept some other messages especially for the crashkernel > parameter which are not so obvious. > > In case you want me to keep other messages I'm fine to do so, of course. > > I could modify the messages to just print the used defaults if you like > that better. > > Another possibility would be to always print the used parameters at the > end of parse_crashkernel().
Let's see what Andrew thinks. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
