On 14/08/17 15:39, Jan Beulich wrote:
>>>> On 14.08.17 at 09:08, <jgr...@suse.com> wrote:
>> --- a/xen/arch/x86/shutdown.c
>> +++ b/xen/arch/x86/shutdown.c
>> @@ -51,7 +51,7 @@ static int reboot_mode;
>> * efi Use the EFI reboot (if running under EFI)
>> */
>> static enum reboot_type reboot_type = BOOT_INVALID;
>> -static void __init set_reboot_type(char *str)
>> +static int __init set_reboot_type(char *str)
>> {
>> for ( ; ; )
>> {
>> @@ -74,6 +74,8 @@ static void __init set_reboot_type(char *str)
>> case 't':
>> reboot_type = *str;
>> break;
>> + default:
>> + return -EINVAL;
>
> This alters behavior - you want to store -EINVAL in a local variable,
> but continue the loop.
Aah, yes. Okay.
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
