>>> On 10.02.16 at 17:44, <ta...@tklengyel.com> wrote:
> On Wed, Feb 10, 2016 at 8:54 AM, Corneliu ZUZU <cz...@bitdefender.com>
> wrote:
>
>> Rename:
>> - arch/x86/monitor_x86.c -> arch/x86/monitor.c
>> - asm-{x86,arm}/monitor_arch.h -> asm-{x86,arm}/monitor.h
>>
>> (previous commit explains why these renames were necessary)
>>
>
> Referencing a "previous commit" like this is not acceptable as you don't
> know how these patches will get applied and there might be other patches
> that get committed in-between yours. In each patch explain clearly why the
> patch is needed. I still find it odd that you need to rename x86/monitor.c
> -> x86/monitor_x86.c -> x86/monitor.c in the same series.
Indeed. Thinking about it again perhaps the operations should be
"move to common/ (mostly) verbatim" followed by "break out x86
specific code" (if that's the smaller portion compared to what is to
stay).
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
