>>> On 11.08.16 at 15:19, <andrew.coop...@citrix.com> wrote: > On 11/08/16 13:04, Jan Beulich wrote: >> @@ -2415,12 +2425,10 @@ x86_emulate( >> break; >> } >> >> - case 0x70 ... 0x7f: /* jcc (short) */ { >> - int rel = insn_fetch_type(int8_t); >> + case 0x70 ... 0x7f: /* jcc (short) */ >> if ( test_cc(b, _regs.eflags) ) >> - jmp_rel(rel); >> + jmp_rel((int32_t)src.val); > > jmp_rel() already contains an explicit (int) cast of its parameter. Is > the (int32_t) actually needed?
Good point - I admit I didn't inspect jmp_rel() when putting this together. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel