>>> On 11.08.16 at 15:41, <andrew.coop...@citrix.com> wrote:
> On 11/08/16 13:05, Jan Beulich wrote:
>> There's no need for having identical code spelled out twice.
>>
>> Signed-off-by: Jan Beulich <jbeul...@suse.com>
>>
>> --- a/xen/arch/x86/x86_emulate/x86_emulate.c
>> +++ b/xen/arch/x86/x86_emulate/x86_emulate.c
>> @@ -1979,9 +1979,12 @@ x86_emulate(
>> goto done;
>> break;
>> case SrcImm:
>> + if ( !(d & ByteOp) )
>> + src.bytes = op_bytes != 8 ? op_bytes : 4;
>> + else
>
> {
>
>> + case SrcImmByte:
>> + src.bytes = 1;
>
> }
I don't understand: This is a single statement, which we don't require
to be surrounded by braces.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
