On 12/14/2016 06:49 AM, Andrew Cooper wrote: > On 14/12/16 11:44, Wei Liu wrote: >> ... otherwise it returns 0 even if the function fails. > > Coverity-ID: 1397121 > >> Signed-off-by: Wei Liu <wei.l...@citrix.com> > > Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> > >> --- >> Cc: Ian Jackson <ian.jack...@eu.citrix.com> >> >> This should be backported to 4.8. >> --- >> tools/libxl/libxl_x86_acpi.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/libxl/libxl_x86_acpi.c b/tools/libxl/libxl_x86_acpi.c >> index 686ac8e..6cf0c30 100644 >> --- a/tools/libxl/libxl_x86_acpi.c >> +++ b/tools/libxl/libxl_x86_acpi.c >> @@ -154,7 +154,7 @@ static int init_acpi_config(libxl__gc *gc, >> config->acpi_revision = 5; >> >> out: >> - return 0; >> + return rc;
This breaks init_acpi_config(): xc_domain_getinfo() at the top of returns a positive number (number of domains). -boris _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
