Wei Liu writes ("Re: [Xen-devel] [PATCH] libxl: init_acpi_config should return rc in exit path"): > I don't think so, because there could be functions that only return >0 > values to indicate error.
The problem here is the violation of the CODING_STYLE which forbids the use of `rc' to contain anything other than a libxl error value. `r' should be used for the values from libxc. And each failure path should set rc. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel